HADOOP-18013. ABFS: add cloud trash policy with per-schema policy selection #4729
+566
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New trash policies, and a schema specific trash policy set by fs.SCHEMA.trash.policy. This lets clusters declare different policies for different stores in the same cluster. Change-Id: I8f4c478ca4d7b763a4499e80b2fe76f4777af054 ResilientTrashPolicy: for abfs with rename failure resilience DeleteFilesTrashPolicy: for versioned s3 buckets; delete the files.
...as RawLocalFS doesn't have a schema Change-Id: I2f0983e7ea67f6cef71e24ebe666e0ff652a85b4
steveloughran
force-pushed
the
azure/HADOOP-18013-resilient-trash-policy
branch
from
054a651
to
4cd392b
Compare
Change-Id: Ie3e676ed023f573162c2de9dd9518d1273ab1215
Stats collection; option to cleanup. ABFS configured to collect the matching stats. no tests/docs Change-Id: I324bf687da1841354748a2d479c287594486dc58
steveloughran
changed the title
|
Still a WiP but should interest people working with abfs/gcs and to a lesser degree s3a |
|
💔 -1 overall
This message was automatically generated. |
xinglin
reviewed
Sep 12, 2022
| trashRoot -> { | ||
| try { | ||
| count.addAndGet(deleteCheckpoint(trashRoot.getPath(), false)); | ||
| createCheckpoint(trashRoot.getPath(), new Date(now)); |
There was a problem hiding this comment.
moveToTrash() will be called by thousands of clients. IIRC, a new snapshot will be created, as long as the CURRENT dir exists. super.moveToTrash() will create the CURRENT dir if it does not exist. So, I'd image every moveToTrash() would create a new checkpoint which is probably not ideal.
Each client will also try to delete the same set of snapshots. I'd image some of clients will fail due to FILE_NOT_FOUND exception, because a checkpoint dir is removed by other clients.
Cleaning is something we need to handle for trash and if we could make this approach work, I would think that would be great.
There was a problem hiding this comment.
hmmm. good explanation of the problems you see.
that auto cleanup was added because of the reported problem of user home dirs being full. maybe we need to think of better strategies here, even if just hadoop fs -expunge updated to work better in this world.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New trash policies, and a schema specific trash policy set by
fs.SCHEMA.trash.policy.
This lets clusters declare different policies for different stores
in the same cluster.
CloudTrashPolicy: for abfs with rename failure resilience and auto cleanup of old checkpoints.DeleteFilesTrashPolicy: for versioned s3 buckets; delete the files.How was this patch tested?
what do you mean, tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?