HADOOP-18371. s3a FS init logs at warn if fs.s3a.create.storage.class is unset #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested against |
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @monthonk. |
ayushtkn
reviewed
Aug 12, 2022
| LOG.warn("Unknown storage class property {}: {}; falling back to default storage class", | ||
| LOG.info("Unknown storage class property {}: {}; falling back to default storage class", |
There was a problem hiding this comment.
If you don't configure anything and then if it is falling back to default, it should be info in that case, but if someone configured it and configured it wrong it should be warn only right? it isn't the normal flow of execution
There was a problem hiding this comment.
Ah, what a miss :(
There was a problem hiding this comment.
Thanks @ayushtkn !
|
Testing in progress |
ayushtkn
reviewed
Aug 12, 2022
| @@ -1001,8 +1001,13 @@ protected RequestFactory createRequestFactory() { | |||
| try { | |||
| storageClass = StorageClass.fromValue(storageClassConf); | |||
| } catch (IllegalArgumentException e) { | |||
| LOG.warn("Unknown storage class property {}: {}; falling back to default storage class", | |||
| STORAGE_CLASS, storageClassConf); | |||
| if (storageClassConf.length() == 0) { | |||
There was a problem hiding this comment.
Can do storageClassConf.isEmpty() rather than calculating the length.
BTW. If it is empty you need not to attempt storageClass = StorageClass.fromValue(storageClassConf); and then land up with this Exception handling
There was a problem hiding this comment.
Sounds good, much cleaner approach
|
Will share the test results in some time. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Endpoint: When run individually, |
| STORAGE_CLASS, storageClassConf); | ||
| } | ||
| } else { | ||
| LOG.info("Empty storage class property {}; falling back to default storage class", |
There was a problem hiding this comment.
We print configuration related logs in debug only unless they are supposed to cause error. So I think this should be debug. right @steveloughran
There was a problem hiding this comment.
Also shouldn't the log message say " Unset" rather than empty?
There was a problem hiding this comment.
yes, debug only, apart from some special cases where there's a risk of incompatibility across versions (dir marker policy). even there i think it is time to retire it.
steveloughran
requested changes
Aug 15, 2022
|
💔 -1 overall
This message was automatically generated. |
mukund-thakur
approved these changes
Aug 15, 2022
mukund-thakur
pushed a commit
that referenced
this pull request
Aug 16, 2022
…class is unset (#4730) Contributed By: Viraj Jasani
|
pushed to branch-3.3 as well. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…class is unset (apache#4730) Contributed By: Viraj Jasani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.