HDFS-16728. RBF throw IndexOutOfBoundsException with disableNameServices #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Aug 11, 2022
| @@ -1765,6 +1765,9 @@ protected List<RemoteLocation> getLocationsForPath(String path, | |||
| locs.add(loc); | |||
| } | |||
| } | |||
| if (locs.isEmpty()) { | |||
| throw new NoLocationException(path, this.subclusterResolver.getClass().getSimpleName()); | |||
There was a problem hiding this comment.
Cleaner to pass this.subclusterResolver.getClass() and do the getSimpleName() in the exception.
| try { | ||
| FsPermission permission = new FsPermission("777"); | ||
| LambdaTestUtils.intercept(NoLocationException.class, | ||
| () -> router.getRouter().getRpcServer() |
There was a problem hiding this comment.
Extract router.getRouter().getRpcServer() and we can make this fit in one line.
slfan1989
reviewed
Aug 12, 2022
| */ | ||
| public class NoLocationException extends IOException { | ||
|
|
||
| private static final long serialVersionUID = 1L; |
There was a problem hiding this comment.
Does this part of the code make sense? Why do we assign a value of 1?
There was a problem hiding this comment.
Yes, serialVersionUID is a universal version identifier for a Serializable class. It's useful for class serialization and deserialization. And 1L has no special meaning. It is just a number that will match 1L as the "other" version id.
The serialVersionUID is a universal version identifier for a Serializable class. Deserialization uses this number to ensure that a loaded class corresponds exactly to a serialized object. If no match is found, then an InvalidClassException is thrown.
|
@goiri @slfan1989 Master, I have updated this patch, please help me review it again. Thanks |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri @slfan1989 Master, ping, please help me review it again？ Thanks |
Hexiaoqiao
approved these changes
Aug 23, 2022
|
@goiri @Hexiaoqiao I have rebased this patch based on the latest trunk. Please help me review and merge it into trunk. Then I will rebase HDFS-16734 on the latest trunk. |
|
🎊 +1 overall
This message was automatically generated. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…ces (apache#4734). Contributed by ZanderXu. Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org> Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
RBF will throw an IndexOutOfBoundsException when the namespace is disabled.
Suppose we have a mount point /a/b -> ns0 -> /a/b and disabled the ns0.
RBF will throw IndexOutOfBoundsException during handling requests with path starting with /a/b.