YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests #4776

ashutoshcipher · 2022-08-20T22:51:59Z

Description of PR

Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2022-08-21T00:34:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 14s		trunk passed
+1 💚	compile	0m 46s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	0m 44s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 48s		trunk passed
+1 💚	mvnsite	0m 48s		trunk passed
+1 💚	javadoc	0m 51s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 41s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 59s		branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	20m 25s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 45s		the patch passed
+1 💚	compile	0m 28s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	0m 28s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 26s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: The patch generated 12 new + 19 unchanged - 20 fixed = 31 total (was 39)
+1 💚	mvnsite	0m 29s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 23s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 29s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests has no data from spotbugs
+1 💚	shadedclient	23m 55s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 29s		hadoop-yarn-server-tests in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		100m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/1/artifact/out/Dockerfile
GITHUB PR	#4776
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 9a6ff63dc9fa 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1e3ddb7`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/1/testReport/
Max. process+thread count	653 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ashutoshcipher · 2022-08-30T08:17:21Z

@aajisaka - Please help in reviewing the PR. Thanks.

ashutoshcipher · 2022-08-30T12:13:28Z

@aajisaka - As discussed, added junit-platform-launcher dependency

hadoop-yetus · 2022-08-30T13:49:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 1s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 9 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 33s		trunk passed
+1 💚	compile	0m 45s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	0m 36s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 43s		trunk passed
+1 💚	mvnsite	0m 39s		trunk passed
+1 💚	javadoc	0m 50s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 33s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 53s		branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	20m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 25s		the patch passed
+1 💚	compile	0m 25s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	0m 25s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 22s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests: The patch generated 12 new + 19 unchanged - 20 fixed = 31 total (was 39)
+1 💚	mvnsite	0m 26s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 🆗	spotbugs	0m 25s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests has no data from spotbugs
+1 💚	shadedclient	19m 40s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 33s		hadoop-yarn-server-tests in the patch passed.
+1 💚	asflicense	0m 49s		The patch does not generate ASF License warnings.
		94m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/2/artifact/out/Dockerfile
GITHUB PR	#4776
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 1aef96862822 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b579b2f`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/2/testReport/
Max. process+thread count	722 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4776/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ashutoshcipher · 2022-09-07T22:20:50Z

@aajisaka - Please help in reviewing the PR. Thanks.

ashutoshcipher · 2022-10-01T17:51:36Z

@aajisaka - Please help in reviewing the PR. Thanks.

ashutoshcipher · 2022-10-09T15:37:12Z

@aajisaka Please help in reviewing the PR. Thank you so much.

aajisaka

LGTM, +1

aajisaka · 2022-10-29T19:13:16Z

BTW, I noticed TimelineVersionWatcher and TimelineVersion are unused. I think they can be removed by a separate jira.

ashutoshcipher · 2022-10-29T19:16:56Z

BTW, I noticed TimelineVersionWatcher and TimelineVersion are unused. I think they can be removed by a separate jira.

Thanks @aajisaka for reviewing. I will create another JIRA to remove unsed TimelineVersionWatcher and TimelineVersionWatcher

JIRA - YARN-11363

aajisaka · 2022-10-29T19:34:30Z

Merged. Thank you for the contribution and opening an additional JIRA!

…ache#4776) Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests

1e3ddb7

Added junit-platform-launcher

b579b2f

aajisaka approved these changes Oct 29, 2022

View reviewed changes

aajisaka merged commit cbe02c2 into apache:trunk Oct 29, 2022

ashutoshcipher mentioned this pull request Nov 1, 2022

YARN-11363. Remove unused TimelineVersionWatcher and TimelineVersion from hadoop-yarn-server-tests #5091

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests #4776

YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests #4776

ashutoshcipher commented Aug 20, 2022

hadoop-yetus commented Aug 21, 2022

ashutoshcipher commented Aug 30, 2022

ashutoshcipher commented Aug 30, 2022

hadoop-yetus commented Aug 30, 2022

ashutoshcipher commented Sep 7, 2022

ashutoshcipher commented Oct 1, 2022

ashutoshcipher commented Oct 9, 2022

aajisaka left a comment

aajisaka commented Oct 29, 2022 •

edited

ashutoshcipher commented Oct 29, 2022 •

edited

aajisaka commented Oct 29, 2022

YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests #4776

YARN-11264. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-tests #4776

Conversation

ashutoshcipher commented Aug 20, 2022

Description of PR

For code changes:

hadoop-yetus commented Aug 21, 2022

ashutoshcipher commented Aug 30, 2022

ashutoshcipher commented Aug 30, 2022

hadoop-yetus commented Aug 30, 2022

ashutoshcipher commented Sep 7, 2022

ashutoshcipher commented Oct 1, 2022

ashutoshcipher commented Oct 9, 2022

aajisaka left a comment

Choose a reason for hiding this comment

aajisaka commented Oct 29, 2022 • edited

ashutoshcipher commented Oct 29, 2022 • edited

aajisaka commented Oct 29, 2022

aajisaka commented Oct 29, 2022 •

edited

ashutoshcipher commented Oct 29, 2022 •

edited