HDFS-16737. Fix number of threads in FsDatasetAsyncDiskService#addExecutorForVolume #4784
+68
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn Sir, can you help me review this patch? |
ayushtkn
reviewed
Aug 24, 2022
There was a problem hiding this comment.
Apart from the config name stuff things looks good to me.
cc. @ferhui / @sodonnel / @tomscut in case you guys have any comments around this since you folks were involved in HDFS-16386
Comment on lines
154
to
156
| public static final String DFS_DATANODE_FSDATASETASYNCDISK_MAX_THREADS_PER_VOLUME_KEY = | ||
| "dfs.datanode.fsdatasetasyncdisk.max.threads.per.volume"; | ||
| public static final int DFS_DATANODE_FSDATASETASYNCDISK_MAX_THREADS_PER_VOLUME_DEFAULT = 4; | ||
| public static final String DFS_DATANODE_FSDATASETASYNCDISK_THREADS_PER_VOLUME_KEY = | ||
| "dfs.datanode.fsdatasetasyncdisk.threads.per.volume"; | ||
| public static final int DFS_DATANODE_FSDATASETASYNCDISK_THREADS_PER_VOLUME_DEFAULT = 1; |
There was a problem hiding this comment.
you can't change the config name if that is there in a released version.
|
@ayushtkn Thanks for your review. About HDFS-16386, the increased memory maybe caused by the stacked async deletion takes, increasing or decreasing the maximum number of threads may cannot fix it. Can increase the corePoolSize of the threadPoolExecutor maybe can reduce the memory. I have updated the patch, please help me review it again. Thanks |
|
💔 -1 overall
This message was automatically generated. |
|
@ayushtkn @jianghuazhu Sir, I added one UT to test the active count and core pool size of the executer. Can you help me review it again. @ferhui @haiyang1987 Masters, can you help me review this PR? |
|
💔 -1 overall
This message was automatically generated. |
haiyang1987
reviewed
Sep 7, 2022
|
The failed UT @Hexiaoqiao Sir, can you help me review this patch too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The number of threads in FsDatasetAsyncDiskService#addExecutorForVolume is elastic right now, make it fixed.
Presently the corePoolSize is set to 1 and maximumPoolSize is set to maxNumThreadsPerVolume, but since the size of Queue is Integer.MAX, the queue doesn't tend to get full and threads are always confined to 1 irrespective of maxNumThreadsPerVolume.