YARN-11275. [Federation] Add batchFinishApplicationMaster in UAMPoolManager. #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Aug 23, 2022
| Map<String, FinishApplicationMasterResponse> responseMap = new HashMap<>(); | ||
| Set<String> subClusterIds = this.unmanagedAppMasterMap.keySet(); | ||
|
|
||
| if (subClusterIds.size() > 0) { |
There was a problem hiding this comment.
Thank you very much for helping to review the code, I will modify the code.
| FinishApplicationMasterResponse finshResponse = | ||
| interceptor.finishApplicationMaster(finishReq); | ||
| Assert.assertNotNull(finshResponse); | ||
| Assert.assertEquals(true, finshResponse.getIsUnregistered()); |
There was a problem hiding this comment.
I will modify the code.
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Please help to review the code again, Thank you very much! |
goiri
approved these changes
Aug 25, 2022
| LOG.info("Sending finish application request to RM {}", subClusterId); | ||
| FinishApplicationMasterResponse uamResponse = null; | ||
| try { | ||
| uamResponse = finishApplicationMaster(subClusterId, request); |
There was a problem hiding this comment.
try {
FinishApplicationMasterResponse uamResponse = finishApplicationMaster(subClusterId, request);
return Collections.singletonMap(subClusterId, uamResponse);
} catch (Throwable e) {
LOG.warn("Failed to finish unmanaged application master: RM address: {} ApplicationId: {}",
subClusterId, appId, e);
return Collections.singletonMap(subClusterId, null);
}
There was a problem hiding this comment.
Thanks for your suggestion, the code looks very good, I will modify it.
| finishReq.setTrackingUrl(""); | ||
| finishReq.setFinalApplicationStatus(FinalApplicationStatus.SUCCEEDED); | ||
|
|
||
| FinishApplicationMasterResponse finshResponse = |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Please help to review the code again, Thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Please help to review the code again, Thank you very much! |
goiri
approved these changes
Aug 26, 2022
|
🎊 +1 overall
This message was automatically generated. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:YARN-11275. [Federation] Add batchFinishApplicationMaster in UAMPoolManager.