Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18449. Upgrade hadolint to 2.10.0 #4876

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

GauthamBanasandra
Copy link
Member

Description of PR

The current version of hadolint (1.11.1) is only suitable for linting Linux commands in Dockerfile. It fails to recognize Windows command syntax.
HADOOP-18133 adds Dockerfile for Windows. Thus, it's essential to upgrade hadolint to 2.10.0 which has the ability to recognize Windows command syntax.

How was this patch tested?

Hadoop Jenkins CI.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

* The current version of hadolint (1.11.1)
  is only suitable for linting Linux
  commands in Dockerfile. It fails to
  recognize Windows command syntax.
* HADOOP-18133 adds Dockerfile for Windows.
  Thus, it's essential to upgrade hadolint
  to 2.10.0 which has the ability to
  recognize Windows command syntax.
@GauthamBanasandra GauthamBanasandra self-assigned this Sep 10, 2022
@GauthamBanasandra GauthamBanasandra force-pushed the upgrade-hadolint branch 4 times, most recently from a343723 to 37aa15d Compare September 13, 2022 14:12
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 14, 2022
@apache apache deleted a comment from hadoop-yetus Sep 15, 2022
@apache apache deleted a comment from hadoop-yetus Sep 15, 2022
@apache apache deleted a comment from hadoop-yetus Sep 15, 2022
@hadoop-yetus
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4876/11/console in case of problems.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 56s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 yamllint 0m 0s yamllint was not available.
+0 🆗 shellcheck 0m 0s Shellcheck was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 8s trunk passed
+1 💚 mvnsite 20m 11s trunk passed
+1 💚 shadedclient 42m 12s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 25m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 hadolint 0m 3s The patch generated 0 new + 0 unchanged - 41 fixed = 0 total (was 41)
+1 💚 mvnsite 19m 42s the patch passed
+1 💚 shadedclient 41m 39s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 21m 59s root in the patch passed.
+1 💚 asflicense 1m 10s The patch does not generate ASF License warnings.
177m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4876/11/artifact/out/Dockerfile
GITHUB PR #4876
Optional Tests dupname asflicense codespell detsecrets yamllint hadolint shellcheck shelldocs mvnsite unit
uname Linux 4ed9ceba5f2d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / da007eb
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4876/11/testReport/
Max. process+thread count 591 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4876/11/console
versions git=2.9.5 maven=3.6.3 hadolint=2.10.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants