HDDS-1113. Remove default dependencies from hadoop-ozone project #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought we fixed this, but I get this error when I build with this patch applied.
|
|
|
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @arp7 the review, I am merging it to the trunk, right now. |
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…ersionUpgrade. Prevent invalid state updations on barrier. * Introduced a additional barrier state NEW. * Add state validations before updating the barrier. * Fix existing TestZkBarrier tests that are disabled and add new tests to verify the intended behavior. Author: Shanthoosh Venkataraman <svenkataraman@linkedin.com> Author: Shanthoosh Venkataraman <santhoshvenkat1988@gmail.com> Reviewers: Jagadish <jagadish@apache.org> Closes apache#490 from shanthoosh/fix_barrier_state_transitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two ways to define common dependencies with maven:
1.) put all the dependencies to the parent project and inherit them
2.) get all the dependencies via transitive dependencies
TLDR; I would like to switch from 1 to 2 in hadoop-ozone
My main problem with the first approach that all the child project get a lot of dependencies independent if they need them or not. Let's imagine that I would like to create a new project (for example a java csi implementation) It doesn't need ozone-client, ozone-common etc, in fact it conflicts with ozone-client. But these jars are always added as of now.
Using transitive dependencies is more safe: we can add the dependencies where we need them and all of the other dependent projects will use them.
See: https://issues.apache.org/jira/browse/HDDS-1113