Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18416. fix ITestS3AIOStatisticsContext test failure #4931

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

mehakmeet
Copy link
Contributor

Follow on to HADOOP-17461.

Description of PR

backport from trunk for test fix, also contains a commented out portion (to be added once prefetch jira is in branch-3.3)

How was this patch tested?

mvn clean verify -Dparallel-tests -DtestsThreadCount=4 -Dscale

[WARNING] Tests run: 417, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 1147, Failures: 0, Errors: 0, Skipped: 146
[ERROR] Tests run: 124, Failures: 0, Errors: 1, Skipped: 10 (timeout error, unrelated)

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Follow on to HADOOP-17461.

Contributed by: Mehakmeet Singh
@mehakmeet
Copy link
Contributor Author

CC: @steveloughran @mukund-thakur. Backport to the trunk test fix, but also contains a commented-out portion as discussed (to be added once prefetch jira is in branch-3.3).

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 39m 8s branch-3.3 passed
+1 💚 compile 0m 44s branch-3.3 passed
+1 💚 checkstyle 0m 41s branch-3.3 passed
+1 💚 mvnsite 0m 51s branch-3.3 passed
+1 💚 javadoc 0m 46s branch-3.3 passed
+1 💚 spotbugs 1m 27s branch-3.3 passed
+1 💚 shadedclient 26m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 42s the patch passed
+1 💚 compile 0m 32s the patch passed
+1 💚 javac 0m 32s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 23s the patch passed
+1 💚 mvnsite 0m 38s the patch passed
+1 💚 javadoc 0m 26s the patch passed
+1 💚 spotbugs 1m 11s the patch passed
+1 💚 shadedclient 25m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 17s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
104m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4931/1/artifact/out/Dockerfile
GITHUB PR #4931
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux cedd50bbc5a4 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / efd684b
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4931/1/testReport/
Max. process+thread count 526 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4931/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

LGTM.

Mehakmeet, you don't need to get a +1 on a simple backport, seeing that yetus is happy is enough. if it's complicate it is still good to get some review, but only looking for risk of regressions, rather than any major change

@mehakmeet
Copy link
Contributor Author

@steveloughran Noted. Wanted to double-check since this has a commented-out bit from the trunk changes. Wanted to see if this was within the coding standard(having a TODO comment in production code). Thanks for letting me know.

@mehakmeet mehakmeet merged commit e5a566c into apache:branch-3.3 Sep 28, 2022
@steveloughran
Copy link
Contributor

you need to cherrypick to the branch-3.3.5 branch too

@mukund-thakur
Copy link
Contributor

Cherrypicked this one in branch-3.3.5 @mehakmeet thank me later :P

mukund-thakur pushed a commit that referenced this pull request Sep 28, 2022
@mehakmeet
Copy link
Contributor Author

@mukund-thakur Thanks! 😄

asfgit pushed a commit that referenced this pull request Apr 25, 2023
Uncomment the S3ATestUtils-side part of the original patch.
asfgit pushed a commit that referenced this pull request Apr 26, 2023
Uncomment the S3ATestUtils-side part of the original patch.
asfgit pushed a commit that referenced this pull request Apr 28, 2023
Uncomment the S3ATestUtils-side part of the original patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants