-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18416. fix ITestS3AIOStatisticsContext test failure #4931
Conversation
Follow on to HADOOP-17461. Contributed by: Mehakmeet Singh
CC: @steveloughran @mukund-thakur. Backport to the trunk test fix, but also contains a commented-out portion as discussed (to be added once prefetch jira is in branch-3.3). |
🎊 +1 overall
This message was automatically generated. |
LGTM. Mehakmeet, you don't need to get a +1 on a simple backport, seeing that yetus is happy is enough. if it's complicate it is still good to get some review, but only looking for risk of regressions, rather than any major change |
@steveloughran Noted. Wanted to double-check since this has a commented-out bit from the trunk changes. Wanted to see if this was within the coding standard(having a TODO comment in production code). Thanks for letting me know. |
you need to cherrypick to the branch-3.3.5 branch too |
Cherrypicked this one in branch-3.3.5 @mehakmeet thank me later :P |
Follow on to HADOOP-17461. Contributed by: Mehakmeet Singh
@mukund-thakur Thanks! 😄 |
Uncomment the S3ATestUtils-side part of the original patch.
Uncomment the S3ATestUtils-side part of the original patch.
Uncomment the S3ATestUtils-side part of the original patch.
Follow on to HADOOP-17461.
Description of PR
backport from trunk for test fix, also contains a commented out portion (to be added once prefetch jira is in branch-3.3)
How was this patch tested?
mvn clean verify -Dparallel-tests -DtestsThreadCount=4 -Dscale
[WARNING] Tests run: 417, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 1147, Failures: 0, Errors: 0, Skipped: 146
[ERROR] Tests run: 124, Failures: 0, Errors: 1, Skipped: 10
(timeout error, unrelated)For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?