HDFS-16628 RBF: Correct target directory when move to trash for kerberos login user. (#4424). Contributed by Xiping Zhang.

[xinglin]

Description of PR

Backport of HDFS-16628 from trunk to branch-3.3. Please merge this PR after #4962.

HDFS-16628 RBF: Correct target directory when move to trash for kerberos login user. (#4424). Contributed by Xiping Zhang.

(cherry picked from commit f8c7e67fdcdf963ef9613c395058cc4e653cd6d7)

How was this patch tested?

mvn test -Dtest="TestRouterTrash"

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.federation.router.TestRouterTrash
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.267 s - in org.apache.hadoop.hdfs.server.federation.router.TestRouterTrash
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	10m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+1 💚	mvninstall	36m 59s		branch-3.3 passed
+1 💚	compile	0m 48s		branch-3.3 passed
+1 💚	checkstyle	0m 47s		branch-3.3 passed
+1 💚	mvnsite	0m 53s		branch-3.3 passed
+1 💚	javadoc	1m 21s		branch-3.3 passed
+1 💚	spotbugs	1m 38s		branch-3.3 passed
+1 💚	shadedclient	25m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 38s		the patch passed
+1 💚	compile	0m 34s		the patch passed
+1 💚	javac	0m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 21s		the patch passed
+1 💚	mvnsite	0m 38s		the patch passed
+1 💚	javadoc	0m 57s		the patch passed
+1 💚	spotbugs	1m 28s		the patch passed
+1 💚	shadedclient	24m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	16m 57s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		125m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4974/1/artifact/out/Dockerfile
GITHUB PR	#4974
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux eb9c479aa5cf 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / 583322d
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4974/1/testReport/
Max. process+thread count	2115 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4974/1/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[aajisaka]

Hi @xinglin, I've merged #4962, so could you rebase the PR for the latest branch-3.3?

[xinglin]

Hi @aajisaka,

Thanks very much for merging #4962. I have rebased this PR. Could you take another look? Thanks a lot!

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 59s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+1 💚	mvninstall	39m 47s		branch-3.3 passed
+1 💚	compile	0m 46s		branch-3.3 passed
+1 💚	checkstyle	0m 36s		branch-3.3 passed
+1 💚	mvnsite	0m 49s		branch-3.3 passed
+1 💚	javadoc	1m 14s		branch-3.3 passed
+1 💚	spotbugs	1m 38s		branch-3.3 passed
+1 💚	shadedclient	26m 32s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 39s		the patch passed
+1 💚	compile	0m 34s		the patch passed
+1 💚	javac	0m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 22s		the patch passed
+1 💚	mvnsite	0m 39s		the patch passed
+1 💚	javadoc	0m 51s		the patch passed
+1 💚	spotbugs	1m 28s		the patch passed
+1 💚	shadedclient	26m 28s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	18m 21s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 47s		The patch does not generate ASF License warnings.
		124m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4974/2/artifact/out/Dockerfile
GITHUB PR	#4974
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 3c006d0cba6a 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / 30b635a
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4974/2/testReport/
Max. process+thread count	2477 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4974/2/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[aajisaka]

Merged. Thank you @xinglin

[xinglin]

Hi @aajisaka,

Thanks for merging it into upstream.

Just notice a nit when backporting this commit to our internal hadoop repo: this commit did not show up as a cherry-pick commit in branch-3.3. Ideally, it should and that way, it is easier for people to understand these are the same change. We may leave it as it is now, as it is not possible to rewrite git commit history.