Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-18488. Cherrypick HADOOP-11245 to branch-3.3 #4997

Merged
merged 1 commit into from Oct 10, 2022
Merged

HADOOP-18488. Cherrypick HADOOP-11245 to branch-3.3 #4997

merged 1 commit into from Oct 10, 2022

Conversation

ashutoshcipher
Copy link
Contributor

@ashutoshcipher ashutoshcipher commented Oct 10, 2022 •
edited

Description of PR

Cherrypick HADOOP-11245 to branch-3.3 - f41a368

JIRA - HADOOP-18488

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@jojochuang
HADOOP-11245. Update NFS gateway to use Netty4 (apache#2832)
55d9acf 
Reviewed-by: Tsz-Wo Nicholas Sze <szetszwo@apache.org>
jojochuang
jojochuang reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a clean cherrypick. +1 pending Jenkins.

@ashutoshcipher
Copy link
Contributor Author

Thanks @jojochuang

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 11m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 5 new or modified test files.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 14m 54s Maven dependency ordering for branch
+1 💚 mvninstall 26m 47s branch-3.3 passed
+1 💚 compile 19m 1s branch-3.3 passed
+1 💚 checkstyle 3m 12s branch-3.3 passed
+1 💚 mvnsite 1m 46s branch-3.3 passed
+1 💚 javadoc 1m 41s branch-3.3 passed
+1 💚 spotbugs 2m 22s branch-3.3 passed
+1 💚 shadedclient 26m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for patch
+1 💚 mvninstall 0m 52s the patch passed
+1 💚 compile 18m 18s the patch passed
+1 💚 javac 18m 18s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 3m 6s /results-checkstyle-root.txt root: The patch generated 19 new + 139 unchanged - 7 fixed = 158 total (was 146)
+1 💚 mvnsite 1m 42s the patch passed
+1 💚 javadoc 1m 35s the patch passed
+1 💚 spotbugs 2m 34s the patch passed
+1 💚 shadedclient 26m 50s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 1m 6s hadoop-nfs in the patch passed.
+1 💚 unit 3m 13s hadoop-hdfs-nfs in the patch passed.
+1 💚 asflicense 1m 8s The patch does not generate ASF License warnings.
173m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4997/1/artifact/out/Dockerfile
GITHUB PR #4997
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 9988f816889d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 55d9acf
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4997/1/testReport/
Max. process+thread count 523 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-nfs hadoop-hdfs-project/hadoop-hdfs-nfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4997/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang jojochuang merged commit 6847ec0 into apache:branch-3.3 Oct 10, 2022
@jojochuang
Copy link
Contributor

Thanks Merged. Checkstyle is unrelated.

asfgit pushed a commit that referenced this pull request Oct 10, 2022
@ashutoshcipher @jojochuang
HADOOP-11245. Update NFS gateway to use Netty4 (#2832) (#4997)
0d067f6 
Reviewed-by: Tsz-Wo Nicholas Sze <szetszwo@apache.org>

Co-authored-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 6847ec0)
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request Oct 11, 2022
@ashutoshcipher @jojochuang
HADOOP-11245. Update NFS gateway to use Netty4 (apache#2832) (apache#…
9ecd7ae 
…4997)

Reviewed-by: Tsz-Wo Nicholas Sze <szetszwo@apache.org>

Co-authored-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 6847ec0)

 Conflicts:
	hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/RpcProgram.java
jojochuang added a commit that referenced this pull request Oct 11, 2022
@jojochuang @ashutoshcipher
HADOOP-11245. Update NFS gateway to use Netty4 (#2832) (#4997) (#4999)
9faebf3 
Reviewed-by: Tsz-Wo Nicholas Sze <szetszwo@apache.org>

Co-authored-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 6847ec0)

 Conflicts:
	hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/RpcProgram.java

Co-authored-by: Ashutosh Gupta <ashutosh.gupta@st.niituniversity.in>
DremioQA pushed a commit to dremio/hadoop that referenced this pull request Jun 14, 2023
@ashutoshcipher @szlta
DX-66673: Backport HADOOP-11245. Update NFS gateway to use Netty4 (ap…
d01e231 
…ache#2832) (apache#4997)

Reviewed-by: Tsz-Wo Nicholas Sze <szetszwo@apache.org>

Co-authored-by: Wei-Chiu Chuang <weichiu@apache.org>
(cherry picked from commit 6847ec0)

Change-Id: I0723da91f430a37d4c021e1283a3f729e68be2c7
DremioQA pushed a commit to dremio/hadoop that referenced this pull request Apr 5, 2024
@DanHuffDremio
DX-88666: Add changes from branch-3.3.2-dremio to 3.3.6
708bddc 
This list captures the current state of non-upstream changes in our branch
that are not in the public repo.

---Changes cherry-picked to branch-3.3.6-dremio from branch-3.3.2-dremio---
The below changes were on branch-3.3.2-dremio and needed to be brought to
branch-3.3.6-dremio to prevent regressing scenarios these changes addressed.

HADOOP-18928: S3AFileSystem URL encodes twice where Path has trailing / (proposed)
DX-69726: Bumping okie from 1.6.0 to 3.4.0 (CVE-2023-3635)
DX-69726: Bumping okie from 1.6.0 to 3.4.0 (CVE-2023-3635)
DX-66470: Allow for custom shared key signer for ABFS
DX-66673: Backport HADOOP-18602. Remove netty3 dependency
DX-66673: Backport MAPREDUCE-7434. Fix ShuffleHandler tests. Contributed by Tamas Domok
DX-66673: Backport MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade. (apache#5311)
DX-66673: Backport HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4 apache#3259. Contributed by Szilard Nemeth.
DX-66673: Backport HADOOP-17115. Replace Guava Sets usage by Hadoop's own Sets in hadoop-common and hadoop-tools (apache#2985)
HADOOP-18676. jettison dependency override in hadoop-common lib
DX-52816: Downgrade azure-data-lake-store-sdk to 2.3.3 to support dremio version.
DX-52701: Remove node based module by Naveen Kumar
DX-32012: Adding BatchList Iterator for ListFiles by “ajmeera.nagaraju”
DX-18552: Make file status check optional in S3AFileSystem create()
Add flag to skip native tests by Laurent Goujon
DX-21904: Support S3 requester-pays headers by Brandon Huang
DX-21471: Fix checking of use of OAuth credentials with AzureNativeFileSystem
DX-19314: make new kms format configurable
DX-17058 Add FileSystem to META-INF/services
DX-17317 Fix incorrect parameter passed into AzureADAuthenticator-getTokenUsingClientCreds by TiffanyLam
DX-17276 Azure AD support for StorageV1 by James Duong
DX-17276 Add Azure AD support in Dremio's hadoop-azure library for Storage V1 support
unwraps BindException in HttpServer2

---Changes picked up by moving to 3.3.6---
The below changes were changes on branch-3.3.2-dremio that did not need to
come to branch-3.3.6-dremio as the public 3.3.6 branch contained the fixes
already.

DX-67500: Backport HADOOP-18136. Verify FileUtils.unTar() handling of missing .tar files.
DX-66673: Backport HADOOP-18079. Upgrade Netty to 4.1.77. (apache#3977)
DX-66673: Backport HADOOP-11245. Update NFS gateway to use Netty4 (apache#2832) (apache#4997)
DX-64051: Bump jettison from 1.1 to 1.5.4 in hadoop/branch-3.3.2-dremio
DX-64051: Bump jettison from 1.1 to 1.5.4 in hadoop/branch-3.3.2-dremio
DX-63800 Bump commons-net from 3.6 to 3.9.0 to address CVE-2021-37533
DX-27168: removing org.codehaus.jackson

Change-Id: I6cdb968e33826105caff96e1c3d2c6313a550689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jojochuang jojochuang jojochuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ashutoshcipher @hadoop-yetus @jojochuang