HDFS-16803.Improve some annotations in hdfs module. #5031

jianghuazhu · 2022-10-14T07:53:02Z

Description of PR

In FSDirRenameOp, some annotations are out of date. The purpose of this pr is to fix them.
Details: HDFS-16803

How was this patch tested?

Not too stressful for testing.

ZanderXu

@jianghuazhu Can you find all the incorrect annotations in the hadoop-hdfs project and fix them together?

jianghuazhu · 2022-10-14T08:52:53Z

This may be a bit more. But I will still try.

hadoop-yetus · 2022-10-14T15:50:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 9s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 55s		trunk passed
+1 💚	compile	1m 27s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 19s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 5s		trunk passed
+1 💚	mvnsite	1m 29s		trunk passed
+1 💚	javadoc	1m 8s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 30s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 36s		trunk passed
+1 💚	shadedclient	25m 39s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 18s		the patch passed
+1 💚	compile	1m 22s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 22s		the patch passed
+1 💚	compile	1m 15s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 15s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 52s		the patch passed
+1 💚	mvnsite	1m 21s		the patch passed
+1 💚	javadoc	0m 52s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 26s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 24s		the patch passed
+1 💚	shadedclient	25m 36s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	360m 22s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		476m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/1/artifact/out/Dockerfile
GITHUB PR	#5031
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 04d614598d4b 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `8fe934e`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/1/testReport/
Max. process+thread count	2075 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

DaveTeng0

looks good! +1

jianghuazhu · 2022-10-15T00:39:49Z

Thanks @DaveTeng0 .

hadoop-yetus · 2022-10-15T01:00:32Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 14s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 28s		Maven dependency ordering for branch
+1 💚	mvninstall	29m 2s		trunk passed
+1 💚	compile	7m 1s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	6m 33s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 31s		trunk passed
+1 💚	mvnsite	3m 40s		trunk passed
+1 💚	javadoc	2m 53s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 30s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 2s		trunk passed
+1 💚	shadedclient	24m 3s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	6m 46s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	6m 46s		the patch passed
+1 💚	compile	6m 26s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	6m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 15s		the patch passed
+1 💚	mvnsite	3m 11s		the patch passed
+1 💚	javadoc	2m 19s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 6s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 57s		the patch passed
+1 💚	shadedclient	24m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 29s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	374m 56s		hadoop-hdfs in the patch passed.
+1 💚	unit	38m 3s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 59s		The patch does not generate ASF License warnings.
		580m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/2/artifact/out/Dockerfile
GITHUB PR	#5031
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 175d9265a556 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `388bb42`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/2/testReport/
Max. process+thread count	3584 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ZanderXu

@jianghuazhu There are some incorrect annotations in DistributedFileSystem.class and Journal.class. Can you take a look and fix them together?

jianghuazhu · 2022-10-15T09:25:40Z

@ZanderXu , thanks for reviewing this pr.
In Journal.java, there is a display annotation error. Such as:

This looks like an error, but you can actually link to FileJournalManager#lastReadableTxId.
It looks right here. What do you think?

ZanderXu · 2022-10-17T02:44:31Z

This looks like an error, but you can actually link to FileJournalManager#lastReadableTxId.

OK. Just keep it. Can take a look at DistributedFileSystem.class?

jianghuazhu · 2022-10-17T02:52:44Z

OK. I will update later.

ZanderXu

LGTM +1. Pending jenkins

hadoop-yetus · 2022-10-17T13:15:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 50s		trunk passed
+1 💚	compile	6m 42s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	6m 16s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 20s		trunk passed
+1 💚	mvnsite	3m 2s		trunk passed
+1 💚	javadoc	2m 23s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	3m 5s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 27s		trunk passed
+1 💚	shadedclient	23m 43s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 23s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s		the patch passed
+1 💚	compile	6m 26s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	6m 26s		the patch passed
+1 💚	compile	6m 1s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	6m 1s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 8s		the patch passed
+1 💚	mvnsite	2m 48s		the patch passed
+1 💚	javadoc	2m 0s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 46s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 28s		the patch passed
+1 💚	shadedclient	23m 41s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	2m 18s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	349m 31s		hadoop-hdfs in the patch passed.
-1 ❌	unit	36m 45s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		545m 46s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/3/artifact/out/Dockerfile
GITHUB PR	#5031
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux a1b68dea4cac 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `20cce0e`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/3/testReport/
Max. process+thread count	3635 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5031/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

jianghuazhu · 2022-10-18T02:36:08Z

Thanks to @ZanderXu for helping review this pr. It looks like the TestRouterRPCMultipleDestinationMountTableResolver failure is not caused by me.
Here are some of my tests:

ashutoshcipher

Thanks @jianghuazhu for your contribution and improving the code. +1

jianghuazhu · 2022-10-20T02:00:09Z

@ashutoshcipher , thank you for helping review this pr.
Can you help with merging into trunk branch, @ZanderXu. Thanks.

ZanderXu · 2022-10-20T02:58:58Z

Merged into trunk. Thanks @jianghuazhu for your contribution and thanks @ashutoshcipher @DaveTeng0 for your review.

ZanderXu reviewed Oct 14, 2022

View reviewed changes

jianghuazhu changed the title ~~HDFS-16803.Improve some annotations in FSDirRenameOp~~ HDFS-16803.Improve some annotations in hdfs module Oct 14, 2022

jianghuazhu force-pushed the HDFS-16803 branch from 8fe934e to 388bb42 Compare October 14, 2022 15:18

DaveTeng0 reviewed Oct 14, 2022

View reviewed changes

ZanderXu reviewed Oct 15, 2022

View reviewed changes

HDFS-16803.Improve some annotations in hdfs module.

20cce0e

jianghuazhu force-pushed the HDFS-16803 branch from 388bb42 to 20cce0e Compare October 17, 2022 04:07

jianghuazhu changed the title ~~HDFS-16803.Improve some annotations in hdfs module~~ HDFS-16803.Improve some annotations in hdfs module. Oct 17, 2022

ZanderXu approved these changes Oct 17, 2022

View reviewed changes

ashutoshcipher approved these changes Oct 19, 2022

View reviewed changes

ZanderXu merged commit c5c00f3 into apache:trunk Oct 20, 2022

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HDFS-16803.Improve some annotations in hdfs module. (apache#5031)

68f5a03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-16803.Improve some annotations in hdfs module. #5031

HDFS-16803.Improve some annotations in hdfs module. #5031

jianghuazhu commented Oct 14, 2022

ZanderXu left a comment

jianghuazhu commented Oct 14, 2022

hadoop-yetus commented Oct 14, 2022

DaveTeng0 left a comment

jianghuazhu commented Oct 15, 2022

hadoop-yetus commented Oct 15, 2022

ZanderXu left a comment

jianghuazhu commented Oct 15, 2022

ZanderXu commented Oct 17, 2022

jianghuazhu commented Oct 17, 2022

ZanderXu left a comment

hadoop-yetus commented Oct 17, 2022

jianghuazhu commented Oct 18, 2022

ashutoshcipher left a comment

jianghuazhu commented Oct 20, 2022

ZanderXu commented Oct 20, 2022

HDFS-16803.Improve some annotations in hdfs module. #5031

HDFS-16803.Improve some annotations in hdfs module. #5031

Conversation

jianghuazhu commented Oct 14, 2022

Description of PR

How was this patch tested?

ZanderXu left a comment

Choose a reason for hiding this comment

jianghuazhu commented Oct 14, 2022

hadoop-yetus commented Oct 14, 2022

DaveTeng0 left a comment

Choose a reason for hiding this comment

jianghuazhu commented Oct 15, 2022

hadoop-yetus commented Oct 15, 2022

ZanderXu left a comment

Choose a reason for hiding this comment

jianghuazhu commented Oct 15, 2022

ZanderXu commented Oct 17, 2022

jianghuazhu commented Oct 17, 2022

ZanderXu left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Oct 17, 2022

jianghuazhu commented Oct 18, 2022

ashutoshcipher left a comment

Choose a reason for hiding this comment

jianghuazhu commented Oct 20, 2022

ZanderXu commented Oct 20, 2022