YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs. #5057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Oct 28, 2022
...-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterServerUtil.java
Show resolved
Hide resolved
| @@ -491,4 +514,24 @@ public static SubClusterId getRandomActiveSubCluster( | |||
| // Randomly choose a SubCluster | |||
| return subClusterIds.get(rand.nextInt(subClusterIds.size())); | |||
| } | |||
|
|
|||
| public static UserGroupInformation setupUser(String userName) { | |||
| /** | ||
| * Class to define admin method,params and arguments. | ||
| */ | ||
| public class AdminMethod { |
There was a problem hiding this comment.
Is there anything really admin about this class?
There was a problem hiding this comment.
This class is created to be used when the RMAdmin interface is called, so this class is called AdminMethod.
|
|
||
| import java.io.IOException; | ||
| import java.lang.reflect.Method; | ||
| import java.util.*; |
| return new String[0]; | ||
| } | ||
|
|
||
| <R> Collection<R> invokeConcurrent(AdminMethod request, Class<R> clazz) |
There was a problem hiding this comment.
Don't we have very similar methods in other places?
Can we refactor?
There was a problem hiding this comment.
Thank you very much for your suggestion, I will refactor this part of the code.
| @@ -200,7 +200,6 @@ public void shutdown() { | |||
| MockNM mockNM = mockNMs.getOrDefault(subClusterId, null); | |||
| try { | |||
| mockNM.unRegisterNode(); | |||
| mockNM = null; | |||
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Nov 2, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Thank you very much for your help in reviewing the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11359. [Federation] Routing admin invocations transparently to multiple RMs.
The YARN Router does not support calling SubCluster's RMAdmin directly.
If we want to use management commands in Federation mode, we still need to find the Yarn client of the specified SubCluster, and then execute the Yarn management command.
The JIRA(YARN-11351) plan will enhance the router's capabilities, provide a set of CLI commands, and execute SubCluster RM management commands on the Router side.
This JIRA (YARN-11359) is a Sub-Task of YARN-11351, the purpose is to create
FederationRMAdminInterceptor, complete multi-RM access support, and complete Junit tests.FederationRMAdminInterceptor contains many methods, which will be implemented separately by submitting PR. This PR only completes the refreshQueues method.