HADOOP-18579. Warn when no region configured. #5230
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Dec 16, 2022
Comment on lines
+105
to
+109
| public static void regionNotConfigured() { | ||
| WARN_ON_REGION_NOT_CONFIGURED.warn("A region has not been configured. Cross region support " | ||
| + "will be removed as part of upgrading S3A to AWS SDK V2. To avoid errors, set the " | ||
| + "bucket's region in {}.", AWS_REGION); | ||
| } |
There was a problem hiding this comment.
Since the method just logs and it is conditional by nature (as opposed to majority of logging methods in this class), to improve the readability, how about passing region name to the method and let it decide whether to warn?
public static void warnIfRegionNotConfigured(String regionName) {
if (StringUtils.isBlank(regionName)) {
WARN_ON_REGION_NOT_CONFIGURED.warn("A region has not been configured. Cross region support "
+ "will be removed as part of upgrading S3A to AWS SDK V2. To avoid errors, set the "
+ "bucket's region in {}.", AWS_REGION);
}
}
| if (StringUtils.isBlank(region)) { | ||
| V2Migration.regionNotConfigured(); | ||
| } | ||
|
|
||
| // endpoint set up is a PITA | ||
| AwsClientBuilder.EndpointConfiguration epr | ||
| = createEndpointConfiguration(parameters.getEndpoint(), |
There was a problem hiding this comment.
nit: getConf().getTrimmed(AWS_REGION) passed to createEndpointConfiguration() can be replaced with region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Jira
Warn when no region has been configured
fs.s3a.endpoint.region. This is to prepare for the SDK V2 upgrade, in which requests to S3 will fail if the client is configured with an incorrect region.How was this patch tested?
Did not set
fs.s3a.endpoint.region, and checked that warning is logged when running an integration test. Set the property, and checked that warning is not logged.Also tested in
eu-west-1by runningmvn -Dparallel-tests -DtestsThreadCount=16 clean verify.