HADOOP-18595. Fix "the the" and friends typos #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neshkeev
commented
Jan 3, 2023
| @@ -122,7 +122,7 @@ Optimised for random IO, specifically the Hadoop `PositionedReadable` | |||
| operations —though `seek(offset); read(byte_buffer)` also benefits. | |||
|
|
|||
| Rather than ask for the whole file, the range of the HTTP request is | |||
| set to that that of the length of data desired in the `read` operation | |||
| set to the length of data desired in the `read` operation | |||
There was a problem hiding this comment.
This wording is better to my taste, please correct me if I'm wrong here
|
🎊 +1 overall
This message was automatically generated. |
dineshchitlangia
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
LGTM, thanks @neshkeev for the improvement.
I see you have touched quite a few files from past releases.
Let us wait for more members to review and sign off on this change.
goiri
approved these changes
Jan 3, 2023
slfan1989
approved these changes
Jan 4, 2023
ayushtkn
reviewed
Jan 4, 2023
|
@ayushtkn , I didn't touch the names of the issues that are in the release notes, only the commentaries to the releases, so I believe no problems should arise here |
|
Those commentaries aren't written explicitly written, they are fetched from the jira itself, it is there in the release notes column of the Jira. To be precise, so that they can be extracted during the release and published, the same would have been published, and if old archived. |
|
@ayushtkn , I restored everything in the |
|
🎊 +1 overall
This message was automatically generated. |
|
Could this PR be merged, please? |
|
@neshkeev Could you pls resolve the conflicts? |
|
@dineshchitlangia , the conflicts have been resolved. It's weird that I haven't gotten the notification about the conflicts in the PR |
Signed-off-by: Nikita Eshkeev <neshkeev@yandex.ru>
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@dineshchitlangia , could you please check if this PR can be merged and merge it if so? |
|
@dineshchitlangia , @ayushtkn , @slfan1989 , please could someone merge the PR? |
|
@neshkeev Thanks for your contribution! I will merge into trunk branch. @goiri @dineshchitlangia @ayushtkn Thank you very much! |
|
@neshkeev We need a jira, can you create one? I created JIRA: HADOOP-18595. Fix "the the" and friends typos, and modified the pr title. Thanks again for your contribution! @neshkeev |
slfan1989
added a commit
that referenced
this pull request
Jan 16, 2023
This reverts commit 4de3112.
slfan1989
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the documentation I noticed a couple of "the the" typos, so I decided to fix them. IDK if I should request a JIRA ticket for it, but if so, please let me know and I'll amend the commit
Please notice that along with "the the" I also took liberty to fix a different typos like "and&" -> "and" and "can has" -> "has".
Also I'd like to inform you that I fixed a couple of "the the" typos in
RELEASENOTES*files. I didn't touch the issues' names, since the linkRELEASENOTES File <-> JIRAmight be important. IDK if I should touch those files, so please advise.