-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18612. Avoid mixing canonical and non-canonical when performing comparisons #5339
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems reasonable.
+1 pending checkstyle
HADOOP-18616. Java 11 JavaDoc fails due to missing package comments #5344 would fix the JavaDoc issues. I pulled that out since it didn't feel right to include unrelated fixes. |
…g comparisons (#5339) Contributed by Steve Vaughan Jr
💔 -1 overall
This message was automatically generated. |
…g comparisons (apache#5339) Contributed by Steve Vaughan Jr
Description of PR
The test mixes canonical and non-canonical paths and then perform comparisons. We can avoid unexpected failures by ensuring that comparisons are always made against canonical forms.
How was this patch tested?
The test was run in an Hadoop development environment docker image to verify that the tests pass.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?