Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18620 Avoid using grizzly-http-* APIs #5356

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

virajjasani
Copy link
Contributor

As discussed on the parent Jira HADOOP-15984, we do not have any grizzly-http-servlet version available that uses Jersey 2 dependencies.

version 2.4.4 contains Jersey 1 artifacts: https://repo1.maven.org/maven2/org/glassfish/grizzly/grizzly-http-servlet/2.4.4/grizzly-http-servlet-2.4.4.pom

The next higher version available is 3.0.0-M1 and it contains Jersey 3 artifacts: https://repo1.maven.org/maven2/org/glassfish/grizzly/grizzly-http-servlet/3.0.0-M1/grizzly-http-servlet-3.0.0-M1.pom

Moreover, we do not use grizzly-http-* modules extensively. We use them only for few tests such that we don't have to implement all the methods of HttpServletResponse for our custom test classes.

We should get rid of grizzly-http-servlet, grizzly-http and grizzly-http-server artifacts of org.glassfish.grizzly and rather implement HttpServletResponse directly to avoid having to depend on grizzly upgrades as part of overall Jersey upgrade.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 25s Maven dependency ordering for branch
+1 💚 mvninstall 30m 38s trunk passed
+1 💚 compile 23m 3s trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 compile 20m 26s trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 checkstyle 3m 44s trunk passed
+1 💚 mvnsite 25m 17s trunk passed
-1 ❌ javadoc 4m 16s /branch-javadoc-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚 javadoc 7m 36s trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗 spotbugs 0m 21s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 33m 19s /branch-spotbugs-root-warnings.html root in trunk has 1 extant spotbugs warnings.
+1 💚 shadedclient 55m 37s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 42s Maven dependency ordering for patch
+1 💚 mvninstall 30m 22s the patch passed
+1 💚 compile 22m 35s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
-1 ❌ javac 22m 35s /results-compile-javac-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 12 new + 2818 unchanged - 0 fixed = 2830 total (was 2818)
+1 💚 compile 20m 32s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
-1 ❌ javac 20m 32s /results-compile-javac-root-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt root-jdkPrivateBuild-1.8.0_352-8u352-ga-120.04-b08 with JDK Private Build-1.8.0_352-8u352-ga-120.04-b08 generated 12 new + 2618 unchanged - 0 fixed = 2630 total (was 2618)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 3m 35s the patch passed
+1 💚 mvnsite 19m 51s the patch passed
-1 ❌ javadoc 3m 58s /patch-javadoc-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚 javadoc 7m 11s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗 spotbugs 0m 20s hadoop-project has no data from spotbugs
+1 💚 shadedclient 55m 52s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 577m 42s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 23s The patch does not generate ASF License warnings.
947m 59s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/2/artifact/out/Dockerfile
GITHUB PR #5356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux befe93aca395 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e913570
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/2/testReport/
Max. process+thread count 3116 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 36s Maven dependency ordering for branch
+1 💚 mvninstall 30m 34s trunk passed
+1 💚 compile 23m 2s trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 compile 20m 32s trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 checkstyle 3m 46s trunk passed
+1 💚 mvnsite 25m 22s trunk passed
-1 ❌ javadoc 4m 7s /branch-javadoc-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚 javadoc 7m 45s trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗 spotbugs 0m 21s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 33m 26s /branch-spotbugs-root-warnings.html root in trunk has 1 extant spotbugs warnings.
+1 💚 shadedclient 56m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 41s Maven dependency ordering for patch
+1 💚 mvninstall 30m 9s the patch passed
+1 💚 compile 22m 38s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
-1 ❌ javac 22m 38s /results-compile-javac-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 12 new + 2819 unchanged - 0 fixed = 2831 total (was 2819)
+1 💚 compile 20m 30s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
-1 ❌ javac 20m 30s /results-compile-javac-root-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt root-jdkPrivateBuild-1.8.0_352-8u352-ga-120.04-b08 with JDK Private Build-1.8.0_352-8u352-ga-120.04-b08 generated 12 new + 2617 unchanged - 0 fixed = 2629 total (was 2617)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 3m 36s the patch passed
+1 💚 mvnsite 19m 55s the patch passed
-1 ❌ javadoc 4m 1s /patch-javadoc-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚 javadoc 7m 18s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗 spotbugs 0m 21s hadoop-project has no data from spotbugs
+1 💚 shadedclient 56m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 597m 29s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 24s The patch does not generate ASF License warnings.
969m 21s
Reason Tests
Failed junit tests hadoop.hdfs.TestLeaseRecovery2
hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/1/artifact/out/Dockerfile
GITHUB PR #5356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 378fd5710c37 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e913570
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/1/testReport/
Max. process+thread count 3473 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 2s Maven dependency ordering for branch
+1 💚 mvninstall 33m 54s trunk passed
+1 💚 compile 25m 9s trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 compile 21m 36s trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 checkstyle 4m 7s trunk passed
+1 💚 mvnsite 26m 21s trunk passed
-1 ❌ javadoc 4m 28s /branch-javadoc-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚 javadoc 7m 46s trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗 spotbugs 0m 16s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌ spotbugs 36m 3s /branch-spotbugs-root-warnings.html root in trunk has 1 extant spotbugs warnings.
+1 💚 shadedclient 61m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 mvninstall 32m 49s the patch passed
+1 💚 compile 24m 49s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
-1 ❌ javac 24m 49s /results-compile-javac-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 12 new + 2818 unchanged - 0 fixed = 2830 total (was 2818)
+1 💚 compile 21m 43s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
-1 ❌ javac 21m 43s /results-compile-javac-root-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt root-jdkPrivateBuild-1.8.0_352-8u352-ga-120.04-b08 with JDK Private Build-1.8.0_352-8u352-ga-120.04-b08 generated 12 new + 2616 unchanged - 0 fixed = 2628 total (was 2616)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 3m 52s the patch passed
+1 💚 mvnsite 20m 56s the patch passed
-1 ❌ javadoc 4m 18s /patch-javadoc-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt root in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
+1 💚 javadoc 7m 21s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 🆗 spotbugs 0m 16s hadoop-project has no data from spotbugs
+1 💚 shadedclient 61m 32s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 784m 4s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 11s The patch does not generate ASF License warnings.
1180m 42s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.ha.TestObserverNode
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/3/artifact/out/Dockerfile
GITHUB PR #5356
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux bb281f3cf539 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / e913570
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/3/testReport/
Max. process+thread count 2051 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5356/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor Author

@aajisaka @slfan1989 could you please review?

@virajjasani
Copy link
Contributor Author

Checkstyle and spotbugs warnings are not relevant

@virajjasani
Copy link
Contributor Author

@jojochuang @cnauroth @liuml07
Could you please review this PR? grizzly dependencies are becoming painful to manage with Jersey.
Thanks

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 let's get this in to unblock other work. THanks @virajjasani for moving it forward!

@jojochuang jojochuang merged commit 4fcceff into apache:trunk Feb 9, 2023
virajjasani added a commit to virajjasani/hadoop that referenced this pull request Feb 9, 2023
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
(cherry-picked from 4fcceff)

Change-Id: Ib25f4cea14a4c509451cf075ff6ac7555852930b
ferdelyi pushed a commit to ferdelyi/hadoop that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants