New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18641. Cut excess dependencies from cloud connectors. #5429
HADOOP-18641. Cut excess dependencies from cloud connectors. #5429
Conversation
+looks like there are things in the distro not in our license. other than the jdk one, all come from aliyun sdk
|
* Exclude imports which come in with hadoop-common * Add explicit import of hadoop's org.codehaus.jettison declaration to hadoop-aliyun * Cut duplicate and inconsistent hbase-server declarations from hadoop-project Change-Id: I529b4243cf31f389b3ad67069559c9c3b1f2efde
9e80cd0
to
d880c84
Compare
Change-Id: Iffaa4c6ebfed5aed6275981ea2dfc25f892d5ccf
Change-Id: Iee1e1182fcbdee190a16e1fe0b75e05d37aec74b
this is a blocker for 3.3.5; please review ASAP. thx |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@steveloughran Why just reverting https://issues.apache.org/jira/browse/HADOOP-18590 is not enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
Pending results from testing of azure in progress.
. If they are good. I am +1.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
HDFS failures, all of which I consider to be race conditions/timing issues and so not blockers. TestDataNodeRollingUpgrade.deleteAndEnsureInTrash
is an assert after some heartbeats
The file was deleted, just didn't show up TestBalancerWithHANameNodes.testBalancerWithObserverWithFailedNode: timeout
TestDFSAdmin.testAllDatanodesReconfigrace condition; created https://issues.apache.org/jira/browse/HDFS-16934 TestFsDatasetImpl.testReportBadBlocks
assert is after a 3s sleep waiting for reports coming in. Going to brittle against delays. creating a jira; LambdaTestUtils.eventually() should be used around this assert
|
different issues. this one is that doing some downstream builds importing hadoop-cloud-storage was bringing in stuff they didn't need, and reviewing that showed some some jar updates hadn't updated the LICENSE-binary with the new version numbers and new transitive dependencies. all test failures are unrelated and created a couple of hdfs jiras for fixing the obvious ones. |
@omalley could you look at this if you get a chance -just build and license fixup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1. ignoring yetus test failures as those are not related
I think wrong Jira Id in the commit message. It mentions HADOOP-18641 but it is actually HADOOP-18642 |
) POM and LICENSE fixup of transient dependencies * Exclude hadoop-cloud-storage imports which come in with hadoop-common * Add explicit import of hadoop's org.codehaus.jettison declaration to hadoop-aliyun * Tune aliyun jars imports * Cut duplicate and inconsistent hbase-server declarations from hadoop-project * Update LICENSE-binary for the current set of libraries in the hadoop 3.3.5 release. Contributed by Steve Loughran
) POM and LICENSE fixup of transient dependencies * Exclude hadoop-cloud-storage imports which come in with hadoop-common * Add explicit import of hadoop's org.codehaus.jettison declaration to hadoop-aliyun * Tune aliyun jars imports * Cut duplicate and inconsistent hbase-server declarations from hadoop-project * Update LICENSE-binary for the current set of libraries. Contributed by Steve Loughran Change-Id: I0c3ed9ac8ebf4e9842563931bb6339946e215676
POM and LICENSE fixup of transient dependencies * Exclude hadoop-cloud-storage imports which come in with hadoop-common * Add explicit import of hadoop's org.codehaus.jettison declaration to hadoop-aliyun * Tune aliyun jars imports * Update LICENSE-binary for the current set of libraries. Contributed by Steve Loughran
POM and LICENSE fixup of transient dependencies * Exclude hadoop-cloud-storage imports which come in with hadoop-common * Add explicit import of hadoop's org.codehaus.jettison declaration to hadoop-aliyun * Tune aliyun jars imports * Cut duplicate and inconsistent hbase-server declarations from hadoop-project * Update LICENSE-binary for the current set of libraries in the hadoop 3.3.5 release. Contributed by Steve Loughran
ooh, no, i've just done that across the board. let me update the jira |
) POM and LICENSE fixup of transient dependencies * Exclude hadoop-cloud-storage imports which come in with hadoop-common * Add explicit import of hadoop's org.codehaus.jettison declaration to hadoop-aliyun * Tune aliyun jars imports * Update LICENSE-binary for the current set of libraries. Contributed by Steve Loughran
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?