YARN-11427. + YARN-11404. Pull up the versioned imports in pom of hadoop-mapreduce-client-app to hadoop-project pom

[susheel-gupta]

Description of PR

How was this patch tested?

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 2s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 51 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	11m 32s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 53s		trunk passed
+1 💚	compile	23m 12s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	20m 34s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	3m 52s		trunk passed
+1 💚	mvnsite	3m 17s		trunk passed
+1 💚	javadoc	3m 4s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 51s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+0 🆗	spotbugs	0m 55s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	20m 54s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 42s		the patch passed
+1 💚	compile	22m 29s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	22m 29s		the patch passed
+1 💚	compile	21m 10s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	21m 10s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 45s	/results-checkstyle-root.txt	root: The patch generated 25 new + 871 unchanged - 78 fixed = 896 total (was 949)
+1 💚	mvnsite	3m 6s		the patch passed
+1 💚	javadoc	2m 35s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 47s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+0 🆗	spotbugs	0m 29s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	21m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 37s		hadoop-project in the patch passed.
+1 💚	unit	9m 8s		hadoop-mapreduce-client-app in the patch passed.
+1 💚	unit	4m 23s		hadoop-mapreduce-client-hs in the patch passed.
+1 💚	unit	124m 58s		hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	asflicense	1m 14s		The patch does not generate ASF License warnings.
		352m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/1/artifact/out/Dockerfile
GITHUB PR	#5465
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 1f1ca85cf9f1 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 57f57ee
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/1/testReport/
Max. process+thread count	1636 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[susheelgupta7]

@bteke I have one query related to this comment of steve #5295 (comment) for versioned imports pull up into the hadoop-project.
Question: Is it good idea to match the version according to hadoop-project pom ?.
Like here in this file it contain different dependency version on comparing hadoop-project pom.
https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore/pom.xml#L62
https://github.com/apache/hadoop/blob/trunk/hadoop-project/pom.xml#L1307

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 51 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	16m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 49s		trunk passed
+1 💚	compile	24m 8s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	21m 28s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	3m 40s		trunk passed
+1 💚	mvnsite	3m 28s		trunk passed
+1 💚	javadoc	3m 17s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	3m 7s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+0 🆗	spotbugs	0m 50s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	20m 25s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 3s		the patch passed
+1 💚	compile	22m 23s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	22m 23s		the patch passed
+1 💚	compile	20m 38s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	20m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	3m 39s	/results-checkstyle-root.txt	root: The patch generated 25 new + 871 unchanged - 78 fixed = 896 total (was 949)
+1 💚	mvnsite	3m 58s		the patch passed
+1 💚	javadoc	3m 28s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	3m 28s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+0 🆗	spotbugs	0m 37s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	20m 51s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 35s		hadoop-project in the patch passed.
+1 💚	unit	9m 13s		hadoop-mapreduce-client-app in the patch passed.
+1 💚	unit	4m 20s		hadoop-mapreduce-client-hs in the patch passed.
-1 ❌	unit	140m 18s	/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt	hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	unit	0m 50s		hadoop-huaweicloud in the patch passed.
+1 💚	asflicense	1m 11s		The patch does not generate ASF License warnings.
		377m 8s

Reason	Tests
Failed junit tests	hadoop.mapreduce.v2.TestMRJobs
	hadoop.mapreduce.v2.TestMRJobsWithProfiler
	hadoop.mapreduce.v2.TestUberAM

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/2/artifact/out/Dockerfile
GITHUB PR	#5465
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 1c137e9af3bd 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / add8f8b
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/2/testReport/
Max. process+thread count	1636 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-cloud-storage-project/hadoop-huaweicloud U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 51 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	16m 5s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 40s		trunk passed
+1 💚	compile	25m 8s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	21m 44s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	4m 3s		trunk passed
+1 💚	mvnsite	3m 14s		trunk passed
+1 💚	javadoc	2m 55s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 36s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+0 🆗	spotbugs	0m 44s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	23m 36s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 53s		the patch passed
+1 💚	compile	24m 24s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	24m 24s		the patch passed
+1 💚	compile	21m 35s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	21m 35s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 0s	/results-checkstyle-root.txt	root: The patch generated 25 new + 871 unchanged - 78 fixed = 896 total (was 949)
+1 💚	mvnsite	3m 11s		the patch passed
+1 💚	javadoc	2m 45s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 38s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+0 🆗	spotbugs	0m 28s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	23m 46s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 28s		hadoop-project in the patch passed.
+1 💚	unit	9m 25s		hadoop-mapreduce-client-app in the patch passed.
+1 💚	unit	4m 32s		hadoop-mapreduce-client-hs in the patch passed.
-1 ❌	unit	139m 20s	/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt	hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	unit	0m 34s		hadoop-huaweicloud in the patch passed.
+1 💚	asflicense	0m 54s		The patch does not generate ASF License warnings.
		382m 58s

Reason	Tests
Failed junit tests	hadoop.mapreduce.v2.TestUberAM
	hadoop.mapreduce.v2.TestMRJobsWithProfiler
	hadoop.mapreduce.v2.TestMRJobs

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/3/artifact/out/Dockerfile
GITHUB PR	#5465
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux dc070622c254 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / ffff89e
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/3/testReport/
Max. process+thread count	1168 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-cloud-storage-project/hadoop-huaweicloud U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5465/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[susheel-gupta]

Below failing testcases are also failing for trunk. Created a new jira to fix this test failure MAPREDUCE-7436.

• TestUberAM#testThreadDumpOnTaskTimeout
• TestMRJobs#testThreadDumpOnTaskTimeout
• TestMRJobsWithProfiler#testDifferentProfilers
• TestMRJobsWithProfiler#testDefaultProfiler.

[susheel-gupta]

@steveloughran Could you please review this PR.
In this PR there are 3 commits: commit1 (is already reviewed by @szilard-nemeth , you can review this if you like) and commit2 + commit3 (commit2 + commit3 require a review) + commit4( empty commit just to trigger build again).

[steveloughran]

the pom move should be separate from the source changes.

I really do not see the point in moving from the original junit calls to the jupiter ones. Seriously: why are we making our lives harder for ourselves unless/until they actually cut the old ones? At which point: why stay with the sessions from a project which is prepared to break existing code.

I know there are some extra features, specifically java8 support and the ability to generate errors dynamically, but AssertJ is really good here and it can coexist with JUnit 4 quite happily.

As you have already done the change, I am =0 on that move. However, be aware that if you ever ask me to review any tests in new code, my response will be "use AssertJ". Is if you don't know it yet -your future PR will be that opportunity. It is a lot better, despite its verbosity.