HDFS-16942. Addendum. Send error to datanode if FBR is rejected due t…

[sodonnel]

Description of PR

Remove the package-info.java and the pom exclusions added in HDFS-16942 as they are breaking the javadoc build.

How was this patch tested?

No changes to core logic.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 53s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 40s		Maven dependency ordering for branch
+1 💚	mvninstall	29m 52s		trunk passed
+1 💚	compile	27m 24s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	23m 23s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	4m 4s		trunk passed
+1 💚	mvnsite	2m 15s		trunk passed
+1 💚	javadoc	1m 48s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 9s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+0 🆗	spotbugs	0m 30s		branch/hadoop-client-modules/hadoop-client-api no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	23m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 25s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 40s		the patch passed
+1 💚	compile	26m 58s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	26m 58s		the patch passed
+1 💚	compile	23m 18s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	23m 18s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	3m 55s		the patch passed
+1 💚	mvnsite	2m 10s		the patch passed
+1 💚	javadoc	1m 40s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 11s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+0 🆗	spotbugs	0m 31s		hadoop-client-modules/hadoop-client-api has no data from spotbugs
+1 💚	shadedclient	22m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	229m 53s		hadoop-hdfs in the patch passed.
+1 💚	unit	0m 46s		hadoop-client-api in the patch passed.
+1 💚	asflicense	1m 12s		The patch does not generate ASF License warnings.
		465m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5478/1/artifact/out/Dockerfile
GITHUB PR	#5478
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux 81633298ddd6 4.15.0-197-generic #208-Ubuntu SMP Tue Nov 1 17:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / f31ffa4
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5478/1/testReport/
Max. process+thread count	2115 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-client-modules/hadoop-client-api U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5478/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[virajjasani]

Wow, checkstyle didn't fail this time (how fragile!).

Maybe does this mean they would only fail if we add new file under the module and not when we update or remove existing file?

Because on #5460, InvalidBlockReportLeaseException was newly added and we got
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/InvalidBlockReportLeaseException.java:1:/**: Missing package-info.java file. [JavadocPackage]

[ayushtkn]

Changes LGTM

[ayushtkn]

Thanx folks, have merged this,