HDDS-1217. Refactor ChillMode rules and chillmode manager. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
bharatviswa504
force-pushed
the
HDDS-1217
branch
from
ab95869
to
4e43b44
Compare
|
Except protected checkstyle warning, remaining all have been addressed. |
|
💔 -1 overall
This message was automatically generated. |
swagle
reviewed
Mar 7, 2019
| * | ||
| * @param <T> | ||
| */ | ||
| public interface ChillModeExitRule<T> { |
There was a problem hiding this comment.
Just food for thought: You could actually still keep this as an interface and provide a default implementation for onMessage. New Java 8 contract change that avoids introducing inheritance purely for a default impl.
There was a problem hiding this comment.
Yes, it can be used but we don't want subclasses to implement this. So in the next patch, I made this method as final in abstract class. This came up when discussing with Nanda, so left this as an abstract class.
But your suggestion can be done, if we don't have such a requirement.
| chillModeCutoff = conf.getDouble( | ||
| HddsConfigKeys.HDDS_SCM_CHILLMODE_THRESHOLD_PCT, | ||
| HddsConfigKeys.HDDS_SCM_CHILLMODE_THRESHOLD_PCT_DEFAULT); | ||
| chillModeManager = manager; | ||
|
|
||
| if (chillModeCutoff > 1.0 || chillModeCutoff < 0.0) { |
There was a problem hiding this comment.
FFT: Guava preconditions might improve readability here.
bharatviswa504
force-pushed
the
HDDS-1217
branch
from
4e43b44
to
257fc60
Compare
|
🎊 +1 overall
This message was automatically generated. |
bharatviswa504
force-pushed
the
HDDS-1217
branch
from
257fc60
to
ed2e04c
Compare
|
💔 -1 overall
This message was automatically generated. |
bharatviswa504
force-pushed
the
HDDS-1217
branch
from
ed2e04c
to
ee72b89
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
| * returns false. | ||
| * @return boolean | ||
| */ | ||
| public abstract boolean validate(); |
There was a problem hiding this comment.
The method can be made protected and all the implementation can also be protected.
| * Actual processing logic for this rule. | ||
| * @param report | ||
| */ | ||
| public abstract void process(T report); |
There was a problem hiding this comment.
This can also be protected.
| /** | ||
| * Cleanup action's need to be done, once this rule is satisfied. | ||
| */ | ||
| public abstract void cleanup(); |
There was a problem hiding this comment.
This can also be protected.
...op-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/chillmode/ChillModeExitRule.java
Show resolved
Hide resolved
nandakumar131
requested changes
Mar 18, 2019
There was a problem hiding this comment.
ChillModeExitRule
We can mandate the event handler adding logic of each and every ChillModeExitRule implementation by introducing an abstract abstract TypedEvent<T> getEventType() method in ChillModeExitRule class. Then we can make a call to this method from ChillModeExitRule constructor. This will mandate each and every rule to provide it's EventType and we can add its event handler in ChillModeExitRule.
public ChillModeExitRule(SCMChillModeManager chillModeManager,
String ruleName, EventQueue eventQueue) {
this.chillModeManager = chillModeManager;
this.ruleName = ruleName;
eventQueue.addHandler(getEventType(), this);
}
bharatviswa504
force-pushed
the
HDDS-1217
branch
from
26b86a8
to
2f76f2b
Compare
|
Thank You @nandakumar131 for the review. |
Done |
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Author: Aditya Toomula <atoomula@linkedin.com> Reviewers: Srini P<spunuru@linkedin.com> Closes apache#558 from atoomula/sql1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.