Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17450. Add Public IOStatistics API -SemaphoredDelegatingExecutor changes #5590

Conversation

steveloughran
Copy link
Contributor

This cherrypicks SemaphoredDelegatingExecutor changes from the trunk commit; somehow it didn't get into the backport to branch-3.3.

Adds a constructor which takes a duration tracker, so can track time spent awaiting an executor.

There may have been a valid reason for the omission., but I don't remember it. Probably related to
the move from guava.

testing: s3a -prefetch branch, aws london

As the rest of the backport is in, if yetus is happy I will merge

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

This cherrypicks SemaphoredDelegatingExecutor from the trunk
commit; somehow it didn't get into the backport to branch-3.3

Change-Id: I8d4a91a92828755594a6c45e37095c372b47cc26
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 37m 10s branch-3.3 passed
+1 💚 compile 17m 50s branch-3.3 passed
+1 💚 checkstyle 1m 1s branch-3.3 passed
+1 💚 mvnsite 1m 39s branch-3.3 passed
+1 💚 javadoc 0m 56s branch-3.3 passed
+1 💚 spotbugs 2m 42s branch-3.3 passed
+1 💚 shadedclient 26m 8s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 58s the patch passed
+1 💚 compile 17m 8s the patch passed
+1 💚 javac 17m 8s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 55s the patch passed
+1 💚 mvnsite 1m 38s the patch passed
+1 💚 javadoc 0m 47s the patch passed
+1 💚 spotbugs 2m 36s the patch passed
+1 💚 shadedclient 25m 47s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 39s hadoop-common in the patch passed.
+1 💚 asflicense 1m 1s The patch does not generate ASF License warnings.
163m 19s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5590/1/artifact/out/Dockerfile
GITHUB PR #5590
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 0b4740ca82d5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / f87e241
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~18.04.1-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5590/1/testReport/
Max. process+thread count 1302 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5590/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran merged commit 21cf507 into apache:branch-3.3 Apr 25, 2023
0 of 2 checks passed
@steveloughran steveloughran deleted the s3/HADOOP-17450-iostats-backport branch April 25, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants