YARN-11492. Improve createJerseyClient#setConnectTimeout Code. #5636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
May 11, 2023
|
|
||
| long connectTimeOut = conf.getTimeDuration(YarnConfiguration.ROUTER_WEBAPP_CONNECT_TIMEOUT, | ||
| YarnConfiguration.DEFAULT_ROUTER_WEBAPP_CONNECT_TIMEOUT, TimeUnit.MILLISECONDS); | ||
| long readTimeout = conf.getTimeDuration(YarnConfiguration.ROUTER_WEBAPP_READ_TIMEOUT, |
There was a problem hiding this comment.
Thank you for your help to review the code! I will modify the code.
| connectTimeOut = TimeUnit.MILLISECONDS.convert( | ||
| YarnConfiguration.DEFAULT_ROUTER_WEBAPP_CONNECT_TIMEOUT, TimeUnit.MILLISECONDS); | ||
| } | ||
| client.setConnectTimeout((int) connectTimeOut); |
| YarnConfiguration configuration = new YarnConfiguration(); | ||
| Client client01 = RouterWebServiceUtil.createJerseyClient(configuration); | ||
| Map<String, Object> properties = client01.getProperties(); | ||
| Object readTimeOut = properties.get(ClientConfig.PROPERTY_READ_TIMEOUT); |
There was a problem hiding this comment.
I will modify the code.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
reviewed
May 24, 2023
Comment on lines
+711
to
+715
| // Case3, Set the maximum value that exceeds the integer | ||
| // We'll get the default timeout(30s) | ||
| YarnConfiguration configuration3 = new YarnConfiguration(); | ||
| long connectTimeOutLong = (long) Integer.MAX_VALUE + 1; | ||
| long readTimeOutLong = (long) Integer.MAX_VALUE + 1; |
There was a problem hiding this comment.
if it is
long connectTimeOutLong = (long) Integer.MAX_VALUE * 3L;
long readTimeOutLong = (long) Integer.MAX_VALUE * 3L;
you won't get the default value I think, because you are relying on the value to go negative when you cast, but post cast it can go +ve as well
There was a problem hiding this comment.
Thank you for helping to review the code! I agree with your point that if users set a very large value for the timeout, it could indeed lead to unexpected timeouts. Generally, this timeout value should not exceed 1 minute. If the user sets a value much larger than this, I will print a warning log to alert them.
Could this approach work?
There was a problem hiding this comment.
I think the correct approach would be first get the long, figure out whether it is -ve or bigger than Integer.MAX and if so put a log and use the default.
If it is within limit, then may be we can do a cast
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11492. Improve createJerseyClient#setConnectTimeout Code.
createJerseyClient#setConnectTimeout There is a type conversion code that converts long to int, we should be careful with this part of code, I added some verification rules.
How was this patch tested?
Add unit tests.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?