YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator. #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
May 19, 2023
| // The expiration time for a subcluster heartbeat, default is 30 minutes | ||
| public static final String GPG_SUBCLUSTER_EXPIRATION_MS = | ||
| FEDERATION_GPG_PREFIX + "subcluster.heartbeat.expiration-ms"; | ||
| public static final long DEFAULT_GPG_SUBCLUSTER_EXPIRATION_MS = 1800000; |
There was a problem hiding this comment.
Make it getTimeDuration() friendly.
There was a problem hiding this comment.
Thank you for helping to review the code, I will improve the code.
| */ | ||
| public SubClusterCleaner(Configuration conf, GPGContext gpgContext) { | ||
| this.heartbeatExpirationMillis = | ||
| conf.getLong(YarnConfiguration.GPG_SUBCLUSTER_EXPIRATION_MS, |
There was a problem hiding this comment.
I will improve the code.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help review this pr? Thank you very much! |
goiri
reviewed
May 24, 2023
...hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
Show resolved
Hide resolved
| @@ -87,10 +100,32 @@ protected void serviceInit(Configuration conf) throws Exception { | |||
| @Override | |||
| protected void serviceStart() throws Exception { | |||
| super.serviceStart(); | |||
|
|
|||
| // Scheduler SubClusterCleaner service | |||
| long scCleanerIntervalMs = getConfig().getLong( | |||
There was a problem hiding this comment.
I will modify the code.
| // The second subcluster didn't heartbeat for two seconds, should mark lost | ||
| subClusterId = subClusterIds.get(1); | ||
| stateStore.setSubClusterLastHeartbeat(subClusterId, | ||
| System.currentTimeMillis() - 2000); |
There was a problem hiding this comment.
Define it as TWO_SECONDS maybe with TimeUnit.SECONDS.toMillis(2)
| The expiration time for a subcluster heartbeat, default is 30 minutes. | ||
| </description> | ||
| <name>yarn.federation.gpg.subcluster.heartbeat.expiration-ms</name> | ||
| <value>1800000</value> |
There was a problem hiding this comment.
Define it with time duration format.
There was a problem hiding this comment.
I will modify this configuration value.
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help review this PR again? Thank you very much! |
goiri
approved these changes
May 29, 2023
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
May 31, 2023
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Thank you very much for your help in reviewing the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-6648. BackPort [GPG] Add SubClusterCleaner in Global Policy Generator.
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?