Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18073. Upgrade S3A in 3.3 branch to AWS SDK V2. #5707

Conversation

ahmarsuhail
Copy link
Contributor

@ahmarsuhail ahmarsuhail commented Jun 1, 2023

Description of PR

Upgrading 3.3 to AWS Java SDK V2.

How was this patch tested?

Tested in eu-west-1 by running mvn -Dparallel-tests -DtestsThreadCount=16 clean verify. Only failure is ITestS3AHugeFilesNoMultipart, this is a known issue: https://issues.apache.org/jira/browse/HADOOP-18749

Will follow up with commit to fix yetus issues and commen out the assertion in ITestS3AHugeFilesNoMultipart.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 3m 56s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 5s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 79 new or modified test files.
_ feature-HADOOP-18073-s3a-sdk-upgrade-3.3 Compile Tests _
+0 🆗 mvndep 51m 18s Maven dependency ordering for branch
+1 💚 mvninstall 23m 54s feature-HADOOP-18073-s3a-sdk-upgrade-3.3 passed
+1 💚 compile 17m 57s feature-HADOOP-18073-s3a-sdk-upgrade-3.3 passed
+1 💚 checkstyle 2m 45s feature-HADOOP-18073-s3a-sdk-upgrade-3.3 passed
+1 💚 mvnsite 3m 13s feature-HADOOP-18073-s3a-sdk-upgrade-3.3 passed
+1 💚 javadoc 2m 22s feature-HADOOP-18073-s3a-sdk-upgrade-3.3 passed
+0 🆗 spotbugs 0m 55s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 24m 35s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 1m 1s Maven dependency ordering for patch
+1 💚 mvninstall 1m 50s the patch passed
+1 💚 compile 17m 13s the patch passed
-1 ❌ javac 17m 13s /results-compile-javac-root.txt root generated 19 new + 1862 unchanged - 17 fixed = 1881 total (was 1879)
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 2m 44s /results-checkstyle-root.txt root: The patch generated 17 new + 73 unchanged - 7 fixed = 90 total (was 80)
+1 💚 mvnsite 3m 14s the patch passed
-1 ❌ javadoc 0m 48s /results-javadoc-javadoc-hadoop-tools_hadoop-aws.txt hadoop-tools_hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+0 🆗 spotbugs 0m 37s hadoop-project has no data from spotbugs
-1 ❌ spotbugs 1m 33s /new-spotbugs-hadoop-tools_hadoop-aws.html hadoop-tools/hadoop-aws generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shadedclient 24m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 36s hadoop-project in the patch passed.
+1 💚 unit 17m 49s hadoop-common in the patch passed.
+1 💚 unit 2m 57s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
220m 26s
Reason Tests
SpotBugs module:hadoop-tools/hadoop-aws
Inconsistent synchronization of org.apache.hadoop.fs.s3a.S3AFileSystem.s3AsyncClient; locked 60% of time Unsynchronized access at S3AFileSystem.java:60% of time Unsynchronized access at S3AFileSystem.java:[line 1764]
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5707/1/artifact/out/Dockerfile
GITHUB PR #5707
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint
uname Linux 13bffca6e03f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision feature-HADOOP-18073-s3a-sdk-upgrade-3.3 / ba5125d
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5707/1/testReport/
Max. process+thread count 1291 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5707/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

+1, merging

@steveloughran steveloughran merged commit 1fe918c into apache:feature-HADOOP-18073-s3a-sdk-upgrade-3.3 Jun 8, 2023
1 of 6 checks passed
steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Jul 19, 2023
steveloughran pushed a commit to steveloughran/hadoop that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants