YARN-11506.The formatted yarn queue list is displayed on CLI #5716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yl09099
changed the title
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Jun 5, 2023
| <dependency> | ||
| <groupId>com.blinkfox</groupId> | ||
| <artifactId>mini-table</artifactId> | ||
| <version>1.0.0</version> |
There was a problem hiding this comment.
This version needs to be added in the parent project, We need to make sure there are no CVE issues.
There was a problem hiding this comment.
Thanks for the advice. I'll check it out
yl09099
force-pushed
the
YARN-11506
branch
2 times, most recently
from
567eda2
to
493e7fa
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Jun 12, 2023
| public FormattingCLIUtils addDatas(Object... objects) { | ||
| return this.appendRows(TableRowType.DATA, objects); | ||
| } | ||
| private FormattingCLIUtils appendRows(TableRowType tableRowType, Object... objects) { |
There was a problem hiding this comment.
Can we add some comments to the method?
There was a problem hiding this comment.
It has been modified, please review it again
slfan1989
approved these changes
Jun 12, 2023
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
4 tasks
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
reviewed
Jun 14, 2023
There was a problem hiding this comment.
minor stuff,
rest can you change "datas" everywhere to "data""
Data itself plural
https://www.britannica.com/dictionary/eb/qa/Is-Data-Singular-or-Plural-#:~:text=Technically%2C%20%22data%22%20is%20a,in%20visitors%20to%20state%20parks.
Comment on lines
79
to
81
| public FormattingCLIUtils addHeaders(Object... objects) { | ||
| return this.appendRows(TableRowType.HEADER, objects); | ||
| } |
Comment on lines
245
to
226
| /** | ||
| * Puts a string in the middle of a given size. | ||
| * @param str | ||
| * @param size | ||
| * @param padChar | ||
| * @return | ||
| */ |
Comment on lines
88
to
89
| public FormattingCLIUtils addDatas(List<?> datas) { | ||
| return this.appendRows(TableRowType.DATA, datas.toArray()); |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@ayushtkn I have modified the problem you mentioned, please help me review it |
ayushtkn
approved these changes
Jun 17, 2023
| * A way to build rows of data. | ||
| * @param datas dataLine | ||
| */ | ||
| private void buildRowLine(List<String> datas) { |
| */ | ||
| private static class TableRow { | ||
| private TableRowType tableRowType; | ||
| private List<String> datas; |
| private void buildTable() { | ||
| this.buildTitle(); | ||
| for (int i = 0, len = this.tableRows.size(); i < len; i++) { | ||
| List<String> datas = this.tableRows.get(i).datas; |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
approved these changes
Jun 17, 2023
|
@slfan1989 @ayushtkn Thank you both for your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YARN-11506.The formatted yarn queue list is displayed on the command line
Original presentation format：
4 queues were found :
Queue Name Queue Path State Capacity Current Capacity Maximum Capacity Weight Maximum Parallel Apps
queueA root.queueA RUNNING 40.00% 50.00% 80.00% -1.00 10
queueB root.queueB RUNNING 40.00% 50.00% 80.00% -1.00 10
queueC root.queueC RUNNING 40.00% 50.00% 80.00% -1.00 10
queueD root.queueD RUNNING 40.00% 50.00% 80.00% -1.00 10
New way of presentation：
+----------------------------------------------------------------------------------------------------------------------+
| 4 queues were found |
+------------+-------------+---------+----------+------------------+------------------+--------+-----------------------+
| Queue Name | Queue Path | State | Capacity | Current Capacity | Maximum Capacity | Weight | Maximum Parallel Apps |
+------------+-------------+---------+----------+------------------+------------------+--------+-----------------------+
| queueA | root.queueA | RUNNING | 40.00% | 50.00% | 80.00% | -1.00 | 10 |
| queueB | root.queueB | RUNNING | 40.00% | 50.00% | 80.00% | -1.00 | 10 |
| queueC | root.queueC | RUNNING | 40.00% | 50.00% | 80.00% | -1.00 | 10 |
| queueD | root.queueD | RUNNING | 40.00% | 50.00% | 80.00% | -1.00 | 10 |
+------------+-------------+---------+----------+------------------+------------------+--------+-----------------------+