HADOOP-18756. S3A prefetch - CachingBlockManager to use AtomicBoolean for closed flag #5718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires rebase after PR #5675 |
|
💔 -1 overall
This message was automatically generated. |
|
@steveloughran i resolved merge conflicts but github has some incidents going on, will likely take some time
|
|
💔 -1 overall
This message was automatically generated. |
This is now resolved |
|
|
steveloughran
requested changes
Jun 8, 2023
| if (numFilesDeleted > 0) { | ||
| LOG.info("Deleted {} cache files", numFilesDeleted); | ||
| if (numFilesDeleted > 0) { | ||
| LOG.info("Deleted {} cache files", numFilesDeleted); |
There was a problem hiding this comment.
downgrade to debug and remove the if() test; we can log the zero count too
|
|
||
| closed = true; | ||
| if (closed.compareAndSet(false, true)) { | ||
| LOG.info(getStats()); |
There was a problem hiding this comment.
could we log this at debug; prefetching is fairly noisy right now
There was a problem hiding this comment.
agree, it is noisy, let me downgrade it to debug
|
💔 -1 overall
This message was automatically generated. |
|
ok. looks good. final check: which s3 store did you run the final build against and what were the settings |
|
my sincere apologies, i thought the addendum was small enough so didn't re-test the whole suite (only tested against ITestS3APrefetchingInputStream and ITestS3APrefetchingCacheFiles). |
re-running this with the addendum change right now. will post here as soon as i get the full results. |
|
test run is complete against |
aah, but you didn't even say you'd tested those two... anyway, thanks for the full run, always good to keep that coverage up. |
steveloughran
requested changes
Jun 12, 2023
| prefetchingStatistics.blockRemovedFromFileCache(); | ||
| numFilesDeleted++; | ||
| } catch (IOException e) { | ||
| LOG.error("Failed to delete cache file {}", entry.path, e); |
There was a problem hiding this comment.
ok, so this is moving from debug to error. why so?
if we do want to print this, it's not an error. at worst a warn.
There was a problem hiding this comment.
sure let me make it at least warn, this is likely going to be rare event and highlighting it would be helpful debugging stale file records in future.
There was a problem hiding this comment.
with this new addendum (log level change: ERROR to WARN), i re-ran the test suite again (without scale profile, since the addendum change is trivial)
There was a problem hiding this comment.
re-tested the latest state of the PR with mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch against us-west-2
|
💔 -1 overall
This message was automatically generated. |
steveloughran
approved these changes
Jun 14, 2023
asfgit
pushed a commit
that referenced
this pull request
Jun 15, 2023
… for closed flag (#5718) Contributed by Viraj Jasani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: HADOOP-18756
Requires rebase after PR #5675