YARN-11510. [Federation] Fix NodeManager#TestFederationInterceptor Flaky Unit Test. #5733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
@goiri Can you help review this pr? Thank you very much! |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jun 12, 2023
| @@ -590,6 +593,10 @@ public Object run() throws Exception { | |||
| interceptor.recover(recoveredDataMap); | |||
|
|
|||
| Assert.assertEquals(1, interceptor.getUnmanagedAMPoolSize()); | |||
|
|
|||
| // Waiting for SC-1 to time out. | |||
| Thread.sleep(800); | |||
There was a problem hiding this comment.
Thank you for your help to review the code! I will modify the code as soon as possible.
| @@ -882,6 +889,10 @@ public Object run() throws Exception { | |||
| int numberOfContainers = 3; | |||
| // Should re-attach secondaries and get the three running containers | |||
| Assert.assertEquals(1, interceptor.getUnmanagedAMPoolSize()); | |||
|
|
|||
| // Waiting for SC-1 to time out. | |||
| Thread.sleep(800); | |||
There was a problem hiding this comment.
I will modify the code.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Jun 15, 2023
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Thank you very much for your help in reviewing the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11510. [Federation] Fix NodeManager#TestFederationInterceptor Flaky Unit Test.
This issue is because
MockResourceManagerFacadedoes not implementCloseable, so it cannot be closed properly.We can solve the issue by letting
MockResourceManagerFacadeimplementsCloseable.This issue is because we need to wait for the timeout of SC-1, which takes 500ms. However, if the program executes very quickly, this process may take less than 500ms, resulting in an assertion error when judging that the subcluster has expired.
We sleep in the program for
800msto ensure thatSC-1times out.This issue is because our registration of UAM and allocation of Containers through AllocateAsync are asynchronous. This is reasonable for production environments, as we can allocate containers once the UAM is successfully registered. However, for testing scenarios, we need to wait for the UAM to be registered before we allocate containers.
Our new configuration parameter is 'yarn.nodemanager.amrmproxy.wait.uam-register.done', which is set to false by default.
In the unit tests, we set 'yarn.nodemanager.amrmproxy.wait.uam-register.done' to true to ensure that UAM has completed registration before allocating containers.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?