HDFS-17116. RBF: Update invoke millisecond time as monotonicNow() in RouterSafemodeService #5876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erval is negative during router safe mode exit check
slfan1989
reviewed
Jul 23, 2023
| @@ -128,7 +129,6 @@ public void testRouterExitSafemode() | |||
|
|
|||
| assertTrue(router.getSafemodeService().isInSafeMode()); | |||
| verifyRouter(RouterServiceState.SAFEMODE); | |||
|
|
|||
There was a problem hiding this comment.
Thanks @slfan1989 help me reivew it, i wll update it later.
slfan1989
reviewed
Jul 23, 2023
| TimeUnit.SECONDS.toMillis(2), TimeUnit.MILLISECONDS) + | ||
| conf.getTimeDuration(DFS_ROUTER_CACHE_TIME_TO_LIVE_MS, | ||
| TimeUnit.SECONDS.toMillis(1), TimeUnit.MILLISECONDS) * 2; | ||
| Thread.sleep(interval); |
There was a problem hiding this comment.
Use GenericTestUtils.waitFor
There was a problem hiding this comment.
i wll update it later.
slfan1989
reviewed
Jul 23, 2023
| verifyRouter(RouterServiceState.SAFEMODE); | ||
|
|
||
| // Wait for initial time in milliseconds | ||
| long interval = |
There was a problem hiding this comment.
This part of the code is not readable, can it be extended？
There was a problem hiding this comment.
i wll update it later.
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
reviewed
Jul 24, 2023
| @@ -161,11 +161,17 @@ protected void serviceInit(Configuration conf) throws Exception { | |||
|
|
|||
| @Override | |||
| public void periodicInvoke() { | |||
| long now = Time.now(); | |||
| long now = now(); | |||
| long delta = now - startupTime; | |||
There was a problem hiding this comment.
How about to invoke monotonicNow() to calculate the delta?
There was a problem hiding this comment.
Thanks @Hexiaoqiao help me review it
yeah, your suggestion is right, because monotonicNow() is not affected by settimeofday or similar system clock changes, if here invoke monotonicNow() to calculate the delta will avoid the exception case.
if startupTime use monotonicNow, maybe cacheLastUpdateTime and enterSafeModeTime we should also use monotonicNow() need to be consistent
what you think?
| assertTrue(router.getSafemodeService().isInSafeMode()); | ||
| verifyRouter(RouterServiceState.SAFEMODE); | ||
|
|
||
| // Wait for initial time in milliseconds |
There was a problem hiding this comment.
One tiny issue, please unify the comments pattern. Add dot in the end of a sentence.
There was a problem hiding this comment.
Thanks @hfutatzhanghb help me reivew it, i wll update it later.
…RouterSafemodeService
haiyang1987
changed the title
haiyang1987
changed the title
|
Hi Sir @Hexiaoqiao @slfan1989 @hfutatzhanghb Update PR and because update implementation need modify the name of the issue. please help me review this pr again when you have free time. Thanks a lot~ |
Hexiaoqiao
approved these changes
Jul 27, 2023
|
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Jul 27, 2023
|
The failed unit test seems unrelated to the change, I will follow up on this UT failure issue and create a new issue to solve it |
|
Committed to trunk. Thanks @haiyang1987 for your contribution and @hfutatzhanghb @slfan1989 for your reviews! |
|
Thanks @Hexiaoqiao @slfan1989 @hfutatzhanghb help me review and merge it. |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…RouterSafemodeService (apache#5876). Contributed by Haiyang Hu. Reviewed-by: hfutatzhanghb <1036798979@qq.com> Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
https://issues.apache.org/jira/browse/HDFS-17116
The following exceptions occurred in our online environment:
The relevant logs are:
Maybe we can be compatible with this case at the code level, can invoke monotonicNow() to calculate the delta.