MAPREDUCE-7449: Add add-opens flag to container launch commands on JDK17 nodes #5935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
LGTM. |
tomicooler
reviewed
Aug 10, 2023
| @@ -170,6 +170,13 @@ public static String expandEnvironment(String var, | |||
| var = var.replace(ApplicationConstants.CLASS_PATH_SEPARATOR, | |||
| File.pathSeparator); | |||
|
|
|||
| if (Shell.isJavaVersionAtLeast(17)) { | |||
There was a problem hiding this comment.
Just wondering about this. Wouldn't a node-manager config be easer to reason about?
Implementing like this is a bit strange, currently MR jobs can be configured (default=true) and the distributed shell app sets this regardless of the configuration. During the job submission/config time it's not clear if container will be launched on a Java>=17 node so that's the reason for the placeholder, later ContainerLaunch replaces it to the arg or an empty string. Maybe non MR apps would also require this option to run properly - which they could specify at the job config - but non-homogenous nodes (where nodes have different Java installs) can't be handled easily (maybe with node labels or some other trick).
I think this should be a node-manager config instead. The ContainerLaunch could just simply add the arg when the java version is at least 17 and the config option is set (if we can detect that the container is a java app, not sure about that).
There was a problem hiding this comment.
Since it is not trivial to detect when and where to add this argument, I think the current solution is OK as is.
There was a problem hiding this comment.
Had an offline discussion with @tomicooler, the issue with not using a placeholder is the way commands is contructed: in contrast to it's name and type it's a String list containing one element only, the command that is to be executed. In case of Java apps we must add this parameter before the main class, hence I see two options here: add the placeholder right after -Xmx (so that we know it'll be in the correct place) or I can deconstruct the first element of the commands array and add the add-opens flag to the correct place. I think the former is a cleaner, less error-prone solution.
|
Unit tests are failing on trunk as well, MAPREDUCE-7436 was opened because of them. |
|
Uploaded a checkstyle fix. I've resolved most of them, however I've left the indentation issues as is, where the rest of the file is similarly indented. |
slfan1989
reviewed
Aug 10, 2023
| " 0" + | ||
| " 1><LOG_DIR>/stdout" + | ||
| " 2><LOG_DIR>/stderr ]", app.launchCmdList.get(0)); | ||
| " -Djava.net.preferIPv4Stack=true" + |
|
@brumi1024 Thank you very much for your contribution! I have a question to ask. Do you compile Hadoop using JDK17 in your production environment, or do you use JDK8 to compile and run it under JDK17? |
slfan1989
approved these changes
Aug 10, 2023
@slfan1989 The latter. I did compile the code using JDK8 and run it on a JDK17 cluster. |
@brumi1024 Thank you very much for your explanation! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
brumi1024
added a commit
to brumi1024/hadoop
that referenced
this pull request
Oct 19, 2023
4 tasks
steveloughran
pushed a commit
that referenced
this pull request
Oct 20, 2023
…K17 nodes (#5935) Contributed by Benjamin Teke
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
To allow containers to launch on JDK17 nodes the add-opens flag should be added to the container launch commands if the node has JDK17+, and it shouldn't on previous JDKs. This behaviour should be configurable.
How was this patch tested?
Tested on a JDK17 cluster.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?