-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18922: Race condition in ZKDelegationTokenSecretManager creating znode #6150
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch. LGTM. +1 from my side.
Confirmed that this avoids issue w/ Apache Solr in apache/solr#1743
One nit comment, I am confused the relationship with apache/solr#1743 from the description of PR.
Apache Solr spins up multiple nodes and uses Hadoop authentication framework for testing. apache/solr#1743 upgraded to Hadoop 3.3.6. This found the race condition. I tested replacing ZKDelegationTokenSecretManager in Apache Solr to make sure this would address the issue. Apache Solr doesn't want to ship modified Hadoop jars so I reverted those changes and put in a workaround to create the necessary znodes before getting to ZKDelegationTokenSecretManager. I would remove the creation of the znode introduced in apache/solr#1743 once a Hadoop release happens with a fix for this. |
Got it. Make sense to me. Will commit while no more comment for two workdays. Thanks. |
Committed to trunk. Thanks @risdenk for your contribution! |
…ng znode (apache#6150). Contributed by Kevin Risden. Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Thanks @Hexiaoqiao backport to branch-3.3 PR - #6179 |
…ng znode (apache#6150). Contributed by Kevin Risden. Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Description of PR
Fixes race condition in ZKDelegationTokenSecretManager creating znode
How was this patch tested?
Confirmed that this avoids issue w/ Apache Solr in apache/solr#1743
For code changes: