HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) #6151

pjfanning · 2023-10-05T20:42:17Z

backport #6133

ayushtkn · 2023-10-05T20:48:42Z

hadoop-yetus · 2023-10-06T01:02:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	9m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	13m 45s		Maven dependency ordering for branch
-1 ❌	mvninstall	39m 23s	/branch-mvninstall-root.txt	root in branch-3.3 failed.
+1 💚	compile	19m 17s		branch-3.3 passed
+1 💚	mvnsite	26m 3s		branch-3.3 passed
-1 ❌	javadoc	7m 12s	/branch-javadoc-root.txt	root in branch-3.3 failed.
-1 ❌	shadedclient	45m 49s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 36s		Maven dependency ordering for patch
-1 ❌	mvninstall	5m 49s	/patch-mvninstall-root.txt	root in the patch failed.
-1 ❌	compile	2m 54s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	javac	2m 54s	/patch-compile-root.txt	root in the patch failed.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-1 ❌	mvnsite	2m 18s	/patch-mvnsite-root.txt	root in the patch failed.
+1 💚	shellcheck	0m 0s		No new issues.
-1 ❌	javadoc	6m 53s	/patch-javadoc-root.txt	root in the patch failed.
-1 ❌	shadedclient	16m 50s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	70m 34s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	0m 51s		The patch does not generate ASF License warnings.
		258m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/1/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 24d20ed73bc4 5.15.0-78-generic #85-Ubuntu SMP Fri Jul 7 15:25:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `8d92356`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/1/testReport/
Max. process+thread count	1239 (vs. ulimit of 5500)
modules	C: hadoop-project . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/1/console
versions	git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-06T11:47:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	13m 9s		Maven dependency ordering for branch
-1 ❌	mvninstall	23m 18s	/branch-mvninstall-root.txt	root in branch-3.3 failed.
+1 💚	compile	13m 16s		branch-3.3 passed
+1 💚	checkstyle	1m 54s		branch-3.3 passed
+1 💚	mvnsite	19m 37s		branch-3.3 passed
-1 ❌	javadoc	5m 9s	/branch-javadoc-root.txt	root in branch-3.3 failed.
+0 🆗	spotbugs	0m 16s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌	shadedclient	44m 7s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
-1 ❌	mvninstall	4m 11s	/patch-mvninstall-root.txt	root in the patch failed.
-1 ❌	compile	2m 1s	/patch-compile-root.txt	root in the patch failed.
-1 ❌	javac	2m 1s	/patch-compile-root.txt	root in the patch failed.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 43s		the patch passed
-1 ❌	mvnsite	1m 38s	/patch-mvnsite-root.txt	root in the patch failed.
+1 💚	shellcheck	0m 0s		No new issues.
-1 ❌	javadoc	5m 24s	/patch-javadoc-root.txt	root in the patch failed.
+0 🆗	spotbugs	0m 16s		hadoop-project has no data from spotbugs
-1 ❌	spotbugs	4m 15s	/patch-spotbugs-root.txt	root in the patch failed.
-1 ❌	shadedclient	8m 23s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	60m 47s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	0m 44s		The patch does not generate ASF License warnings.
		217m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/2/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname	Linux f0a9ce5a93a1 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `b2ebd2d`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/2/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-tools/hadoop-azure . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/2/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-07T02:50:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	13m 37s		Maven dependency ordering for branch
-1 ❌	mvninstall	33m 17s	/branch-mvninstall-root.txt	root in branch-3.3 failed.
+1 💚	compile	12m 34s		branch-3.3 passed
+1 💚	checkstyle	1m 43s		branch-3.3 passed
+1 💚	mvnsite	19m 13s		branch-3.3 passed
-1 ❌	javadoc	5m 2s	/branch-javadoc-root.txt	root in branch-3.3 failed.
+0 🆗	spotbugs	0m 17s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
-1 ❌	shadedclient	44m 23s		branch has errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
-1 ❌	mvninstall	26m 10s	/patch-mvninstall-root.txt	root in the patch failed.
+1 💚	compile	12m 5s		the patch passed
-1 ❌	javac	12m 5s	/results-compile-javac-root.txt	root generated 5 new + 1810 unchanged - 68 fixed = 1815 total (was 1878)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 40s		the patch passed
+1 💚	mvnsite	15m 24s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
-1 ❌	javadoc	5m 5s	/patch-javadoc-root.txt	root in the patch failed.
+0 🆗	spotbugs	0m 17s		hadoop-project has no data from spotbugs
-1 ❌	shadedclient	43m 54s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	617m 49s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 15s		The patch does not generate ASF License warnings.
		867m 10s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerAutoQueueCreation
	hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/3/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 366ddca0a771 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `9373c7c`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/3/testReport/
Max. process+thread count	3287 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-azure . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/3/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-13T00:14:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	14m 42s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 11s		branch-3.3 passed
+1 💚	compile	13m 23s		branch-3.3 passed
+1 💚	checkstyle	2m 2s		branch-3.3 passed
+1 💚	mvnsite	20m 11s		branch-3.3 passed
+1 💚	javadoc	5m 20s		branch-3.3 passed
+0 🆗	spotbugs	0m 17s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	47m 24s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
-1 ❌	mvninstall	28m 11s	/patch-mvninstall-root.txt	root in the patch failed.
+1 💚	compile	12m 59s		the patch passed
-1 ❌	javac	12m 59s	/results-compile-javac-root.txt	root generated 5 new + 1810 unchanged - 68 fixed = 1815 total (was 1878)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 54s		the patch passed
+1 💚	mvnsite	16m 10s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
-1 ❌	javadoc	5m 15s	/patch-javadoc-root.txt	root in the patch failed.
+0 🆗	spotbugs	0m 18s		hadoop-project has no data from spotbugs
-1 ❌	shadedclient	51m 55s		patch has errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	621m 48s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 19s		The patch does not generate ASF License warnings.
		885m 42s

Reason	Tests
Failed junit tests	hadoop.hdfs.tools.TestDFSAdmin
	hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.security.TestRaceWhenRelogin
	hadoop.yarn.sls.TestSLSRunner

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/4/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 7e7a7df47bf1 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `404c08c`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/4/testReport/
Max. process+thread count	3410 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-azure . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/4/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

pjfanning · 2023-10-13T09:36:38Z

This is now blocked by https://issues.apache.org/jira/browse/HADOOP-18916 - commons-io 2.14.0 jar has module-info.class

steveloughran · 2023-10-13T19:02:40Z

#6131 is in trunk now

pjfanning · 2023-10-13T22:02:21Z

@steveloughran I have a backport PR for the module-info classes at #6188

hadoop-yetus · 2023-10-14T23:22:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	14m 29s		Maven dependency ordering for branch
+1 💚	mvninstall	22m 28s		branch-3.3 passed
+1 💚	compile	11m 53s		branch-3.3 passed
+1 💚	checkstyle	1m 46s		branch-3.3 passed
+1 💚	mvnsite	19m 16s		branch-3.3 passed
+1 💚	javadoc	4m 55s		branch-3.3 passed
+0 🆗	spotbugs	0m 17s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	43m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
+1 💚	mvninstall	23m 3s		the patch passed
+1 💚	compile	11m 32s		the patch passed
-1 ❌	javac	11m 32s	/results-compile-javac-root.txt	root generated 5 new + 1810 unchanged - 68 fixed = 1815 total (was 1878)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 41s		the patch passed
+1 💚	mvnsite	15m 11s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	4m 48s		the patch passed
+0 🆗	spotbugs	0m 18s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	43m 8s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	615m 34s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 18s		The patch does not generate ASF License warnings.
		847m 12s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.balancer.TestBalancer
	hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/5/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 6835631fbc49 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `400e2c3`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/5/testReport/
Max. process+thread count	3534 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-azure . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/5/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn

LGTM.
javac warning looks strange & unrelated
A part of this PR comes from HADOOP-18301.

Test failures look unrelated, I will run them once locally before merging this

hadoop-yetus · 2023-10-22T03:11:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	15m 26s		Maven dependency ordering for branch
+1 💚	mvninstall	35m 35s		branch-3.3 passed
+1 💚	compile	19m 12s		branch-3.3 passed
+1 💚	checkstyle	2m 38s		branch-3.3 passed
+1 💚	mvnsite	26m 58s		branch-3.3 passed
+1 💚	javadoc	7m 29s		branch-3.3 passed
+0 🆗	spotbugs	0m 19s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	71m 45s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 36s		Maven dependency ordering for patch
+1 💚	mvninstall	37m 44s		the patch passed
+1 💚	compile	19m 7s		the patch passed
-1 ❌	javac	19m 7s	/results-compile-javac-root.txt	root generated 6 new + 1810 unchanged - 69 fixed = 1816 total (was 1879)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 38s		the patch passed
+1 💚	mvnsite	22m 1s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	7m 20s		the patch passed
+0 🆗	spotbugs	0m 20s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	68m 23s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	404m 58s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	1m 14s		The patch does not generate ASF License warnings.
		759m 44s

Reason	Tests
Failed junit tests	hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6151/1/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname	Linux f5c41c03385c 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `400e2c3`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6151/1/testReport/
Max. process+thread count	3893 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-azure . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6151/1/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn · 2023-10-27T04:11:21Z

Can you check the failures and javac warnings, on trunk everything was green..

… by PJ Fanning Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>

…ontributed by PJ Fanning Co-authored-by: Ayush Saxena <ayushsaxena@apache.org>

pjfanning · 2023-10-27T15:33:19Z

@ayushtkn I added 2561508 but I'm wondering if in hadoop 3.3 that it might be better to use deprecated methods instead of new ones. I have a new PR for trunk that also has these changes but it might be safer to only apply the uptake of the new methods in trunk.

ayushtkn · 2023-10-27T16:44:43Z

Unless they have any user facing changes, I think we are safe, but if something change at the end user side, then maybe we can explore using the deprecated ones only

hadoop-yetus · 2023-10-27T20:17:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 5 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	14m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	27m 35s		branch-3.3 passed
+1 💚	compile	12m 3s		branch-3.3 passed
+1 💚	checkstyle	1m 48s		branch-3.3 passed
+1 💚	mvnsite	18m 59s		branch-3.3 passed
+1 💚	javadoc	5m 13s		branch-3.3 passed
+0 🆗	spotbugs	0m 17s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	41m 56s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	23m 25s		the patch passed
+1 💚	compile	11m 31s		the patch passed
-1 ❌	javac	11m 31s	/results-compile-javac-root.txt	root generated 1 new + 1810 unchanged - 68 fixed = 1811 total (was 1878)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 40s		the patch passed
+1 💚	mvnsite	15m 5s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	4m 50s		the patch passed
+0 🆗	spotbugs	0m 17s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	43m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	359m 45s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	1m 3s		The patch does not generate ASF License warnings.
		597m 44s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.security.TestRaceWhenRelogin

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/6/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname	Linux f4d5043f5de3 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `2561508`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/6/testReport/
Max. process+thread count	3474 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-azure . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/6/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-28T06:25:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 5 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	14m 58s		Maven dependency ordering for branch
+1 💚	mvninstall	22m 49s		branch-3.3 passed
+1 💚	compile	12m 5s		branch-3.3 passed
+1 💚	checkstyle	1m 45s		branch-3.3 passed
+1 💚	mvnsite	19m 21s		branch-3.3 passed
+1 💚	javadoc	4m 59s		branch-3.3 passed
+0 🆗	spotbugs	0m 18s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	43m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	24m 13s		the patch passed
+1 💚	compile	11m 43s		the patch passed
+1 💚	javac	11m 43s		root generated 0 new + 1810 unchanged - 68 fixed = 1810 total (was 1878)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 48s		the patch passed
+1 💚	mvnsite	14m 2s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	4m 27s		the patch passed
+0 🆗	spotbugs	0m 16s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	42m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	359m 26s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	1m 3s		The patch does not generate ASF License warnings.
		596m 3s

Reason	Tests
Failed junit tests	hadoop.hdfs.web.TestWebHDFS
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
	hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
	hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/7/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 0a96f119717b 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `ebca650`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/7/testReport/
Max. process+thread count	3560 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-azure . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/7/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-29T17:47:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+0 🆗	shelldocs	0m 1s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 5 new or modified test files.
			_ branch-3.3 Compile Tests _
+0 🆗	mvndep	15m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	22m 44s		branch-3.3 passed
+1 💚	compile	11m 6s		branch-3.3 passed
+1 💚	checkstyle	1m 49s		branch-3.3 passed
+1 💚	mvnsite	19m 47s		branch-3.3 passed
+1 💚	javadoc	4m 51s		branch-3.3 passed
+0 🆗	spotbugs	0m 16s		branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚	shadedclient	42m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 30s		Maven dependency ordering for patch
+1 💚	mvninstall	24m 13s		the patch passed
+1 💚	compile	11m 29s		the patch passed
+1 💚	javac	11m 29s		root generated 0 new + 1810 unchanged - 68 fixed = 1810 total (was 1878)
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 39s		the patch passed
+1 💚	mvnsite	15m 11s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	javadoc	4m 53s		the patch passed
+0 🆗	spotbugs	0m 18s		hadoop-project has no data from spotbugs
+1 💚	shadedclient	43m 58s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	357m 21s	/patch-unit-root.txt	root in the patch failed.
+1 💚	asflicense	1m 3s		The patch does not generate ASF License warnings.
		595m 32s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
	hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
	hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/8/artifact/out/Dockerfile
GITHUB PR	#6151
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint shellcheck shelldocs
uname	Linux 9b842b864dad 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	branch-3.3 / `ebca650`
Default Java	Private Build-1.8.0_362-8u372-ga~~us1-0ubuntu1~~18.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/8/testReport/
Max. process+thread count	3566 (vs. ulimit of 5500)
modules	C: hadoop-project hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-tools/hadoop-archive-logs hadoop-tools/hadoop-azure . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6151/8/console
versions	git=2.17.1 maven=3.6.0 spotbugs=4.2.2 shellcheck=0.4.6
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

pjfanning · 2023-10-29T18:18:24Z

There are some broken tests that need review.

hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

possibly also hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery

pjfanning · 2023-10-29T20:52:39Z

looks like the broken tests are already broken - see this unrelated PR but similar test failures there too

pjfanning marked this pull request as draft October 5, 2023 20:53

pjfanning marked this pull request as ready for review October 12, 2023 09:25

pjfanning force-pushed the HADOOP-18917-backport branch from 9373c7c to 404c08c Compare October 12, 2023 09:27

pjfanning force-pushed the HADOOP-18917-backport branch from 404c08c to 400e2c3 Compare October 14, 2023 09:14

ayushtkn approved these changes Oct 17, 2023

View reviewed changes

pjfanning and others added 4 commits October 27, 2023 11:04

HADOOP-18917. Upgrade to commons-io 2.14.0 (apache#6133). Contributed…

8a3f3ae

… by PJ Fanning Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>

HADOOP-18917. Addendum: Upgrade to commons-io 2.14.0 (apache#6152). C…

c3dba1b

…ontributed by PJ Fanning Co-authored-by: Ayush Saxena <ayushsaxena@apache.org>

remove redundant catch

d8dc6b1

fix deprecation issues after commons-io upgrade

2561508

pjfanning force-pushed the HADOOP-18917-backport branch from 400e2c3 to 2561508 Compare October 27, 2023 10:17

another deprecation

ebca650

pjfanning mentioned this pull request Oct 29, 2023

HADOOP-18917. Addendum. Fix deprecation issues after commons-io upgrade. #6228

Merged

4 tasks

pjfanning marked this pull request as draft October 29, 2023 18:16

pjfanning marked this pull request as ready for review October 29, 2023 20:51

ayushtkn merged commit 09c4f50 into apache:branch-3.3 Oct 30, 2023
0 of 3 checks passed

pjfanning deleted the HADOOP-18917-backport branch October 30, 2023 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) #6151

HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) #6151

pjfanning commented Oct 5, 2023

ayushtkn commented Oct 5, 2023

hadoop-yetus commented Oct 6, 2023

hadoop-yetus commented Oct 6, 2023

hadoop-yetus commented Oct 7, 2023

hadoop-yetus commented Oct 13, 2023

pjfanning commented Oct 13, 2023

steveloughran commented Oct 13, 2023

pjfanning commented Oct 13, 2023

hadoop-yetus commented Oct 14, 2023

ayushtkn left a comment

hadoop-yetus commented Oct 22, 2023

ayushtkn commented Oct 27, 2023

pjfanning commented Oct 27, 2023

ayushtkn commented Oct 27, 2023

hadoop-yetus commented Oct 27, 2023

hadoop-yetus commented Oct 28, 2023

hadoop-yetus commented Oct 29, 2023

pjfanning commented Oct 29, 2023

pjfanning commented Oct 29, 2023

HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) #6151

HADOOP-18917. Upgrade to commons-io 2.14.0 (#6133) #6151

Conversation

pjfanning commented Oct 5, 2023

ayushtkn commented Oct 5, 2023

hadoop-yetus commented Oct 6, 2023

hadoop-yetus commented Oct 6, 2023

hadoop-yetus commented Oct 7, 2023

hadoop-yetus commented Oct 13, 2023

pjfanning commented Oct 13, 2023

steveloughran commented Oct 13, 2023

pjfanning commented Oct 13, 2023

hadoop-yetus commented Oct 14, 2023

ayushtkn left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Oct 22, 2023

ayushtkn commented Oct 27, 2023

pjfanning commented Oct 27, 2023

ayushtkn commented Oct 27, 2023

hadoop-yetus commented Oct 27, 2023

hadoop-yetus commented Oct 28, 2023

hadoop-yetus commented Oct 29, 2023

pjfanning commented Oct 29, 2023

pjfanning commented Oct 29, 2023