-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11613. [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of Queues. #6295
Conversation
…onfiguration Of Queues.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The failed unit test looks fishy and related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix unit test.
💔 -1 overall
This message was automatically generated. |
@goiri Thank you very much for your help in reviewing the code! I will fix it. |
🎊 +1 overall
This message was automatically generated. |
} | ||
|
||
public DeleteSubClusterPoliciesConfigurationsResponsePBImpl( | ||
DeleteSubClusterPoliciesConfigurationsResponseProto proto) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a checkstyle issue here.
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@goiri Thank you very much for your help in reviewing the code! |
…onfiguration Of Queues. (apache#6295) Contributed by Shilun Fan. Reviewed-by: Inigo Goiri <inigoiri@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Description of PR
JIRA: YARN-11613. [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of Queues.
How was this patch tested?
Add Junit Test.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?