Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18959. Use builder for prefetch CachingBlockManager. (#6240) #6302

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

virajjasani
Copy link
Contributor

branch-3.3 backport PR of #6240

@virajjasani
Copy link
Contributor Author

Testing in progress

@virajjasani
Copy link
Contributor Author

FYI @ahmarsuhail

@virajjasani
Copy link
Contributor Author

Tested against us-west-2

mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 6m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 14m 49s Maven dependency ordering for branch
+1 💚 mvninstall 34m 56s branch-3.3 passed
+1 💚 compile 18m 36s branch-3.3 passed
+1 💚 checkstyle 2m 49s branch-3.3 passed
+1 💚 mvnsite 2m 38s branch-3.3 passed
+1 💚 javadoc 1m 40s branch-3.3 passed
+1 💚 spotbugs 3m 56s branch-3.3 passed
+1 💚 shadedclient 35m 28s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 mvninstall 1m 39s the patch passed
+1 💚 compile 17m 55s the patch passed
+1 💚 javac 17m 55s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 2m 39s the patch passed
+1 💚 mvnsite 2m 35s the patch passed
+1 💚 javadoc 1m 35s the patch passed
+1 💚 spotbugs 4m 12s the patch passed
+1 💚 shadedclient 35m 39s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 28s hadoop-common in the patch passed.
+1 💚 unit 2m 44s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
215m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6302/1/artifact/out/Dockerfile
GITHUB PR #6302
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 8975975f556c 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / ea8bc8e
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6302/1/testReport/
Max. process+thread count 1252 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6302/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor Author

@ahmarsuhail since the original PR is merged to trunk and this is backport with clean build and scale testing done, could you please help review/merge so that upcoming 3.3.x or 3.4.0 release doesn't miss it? (otherwise we might have to deal with backward compatibility issues) :)

@ahmarsuhail
Copy link
Contributor

@virajjasani I recently cut the 3.4.0 branch..so I'm just checking where things should be backported to now. Will do this once I have some clarity there.

@virajjasani
Copy link
Contributor Author

Sounds good, thanks @ahmarsuhail. For branch-3.4, this will be clean cherry-pick since it was just cut recently.

@slfan1989
Copy link
Contributor

slfan1989 commented Jan 5, 2024

@virajjasani Thanks for your reminder! I modified the version to 3.4.0, the PR will be merged to branch3.3 soon. @ahmarsuhail Can you help review this PR? Thank you very much!

@slfan1989 slfan1989 merged commit 585f966 into apache:branch-3.3 Jan 21, 2024
3 checks passed
@slfan1989
Copy link
Contributor

@virajjasani Thanks for the contribution! merge into branch-3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants