HADOOP-19011. Possible ConcurrentModificationException if Exec command fails

[adoroszlai]

What changes were proposed in this pull request?

Fix:

ConcurrentModificationException
    at java.util.ArrayList$Itr.checkForComodification (ArrayList.java:1013)
    at java.util.ArrayList$Itr.next (ArrayList.java:967)
    at org.apache.hadoop.maven.plugin.util.Exec.run (Exec.java:77)
    at org.apache.hadoop.maven.plugin.util.Exec.run (Exec.java:52)
    at org.apache.hadoop.maven.plugin.versioninfo.VersionInfoMojo.determineSCM (VersionInfoMojo.java:115)
    at org.apache.hadoop.maven.plugin.versioninfo.VersionInfoMojo.execute (VersionInfoMojo.java:80)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)

which is possible if the process exits with error:

[INFO] --- hadoop-maven-plugins:3.3.6:version-info (version-info) @ ozone-common ---
[WARNING] [git, branch] failed with error code 128
...
[INFO] BUILD FAILURE
...
[ERROR] Failed to execute goal org.apache.hadoop:hadoop-maven-plugins:3.3.6:version-info (version-info) on project ozone-common: java.util.ConcurrentModificationException

which happens when building sources from tarball, not from git repo.

https://issues.apache.org/jira/browse/HADOOP-19011

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	43m 35s		trunk passed
+1 💚	compile	0m 26s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 26s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	0m 25s		trunk passed
+1 💚	mvnsite	0m 30s		trunk passed
+1 💚	javadoc	0m 30s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	0m 43s		trunk passed
+1 💚	shadedclient	32m 3s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 18s		the patch passed
+1 💚	compile	0m 18s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 18s		the patch passed
+1 💚	compile	0m 18s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	0m 18s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 13s		the patch passed
+1 💚	mvnsite	0m 20s		the patch passed
+1 💚	javadoc	0m 17s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 17s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	0m 43s		the patch passed
+1 💚	shadedclient	32m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 23s		hadoop-maven-plugins in the patch passed.
+1 💚	asflicense	0m 33s		The patch does not generate ASF License warnings.
		119m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6353/1/artifact/out/Dockerfile
GITHUB PR	#6353
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 0a9af42ebf62 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / c8244bb
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6353/1/testReport/
Max. process+thread count	679 (vs. ulimit of 5500)
modules	C: hadoop-maven-plugins U: hadoop-maven-plugins
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6353/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[szetszwo]

+1 the change looks good.

[adoroszlai]

Thanks @szetszwo for the review.