New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19014. Jackson 2.14.3 requiring jsr311-compat #6370
Conversation
💔 -1 overall
This message was automatically generated. |
@@ -921,6 +921,11 @@ | |||
</exclusion> | |||
</exclusions> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have a comment above to explain, maybe something on L72 to say why we've had problems with jackson updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add some comments and recheck the dependency scopes.
<dependency> | ||
<groupId>com.github.pjfanning</groupId> | ||
<artifactId>jsr311-compat</artifactId> | ||
<scope>runtime</scope> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will break if this is not on the classpath?
I'm happy with this, just need to understand if there are any problems with it being optional we will need to add in release notes as incompatible and explain the issue and why the jar should be excluded if you do have the jax-rs stuff on the cp, and that findclass can always be used to work out where the class is from |
025ad17
to
a08b99e
Compare
💔 -1 overall
This message was automatically generated. |
I'm going to come back to this but in a few weeks. There are some incompatibilities showing up in testing and I want to have a closer look. I have a few days off this week so I don't want to delay the 3.4.0 branching. |
Description of PR
HADOOP-19014
see https://github.com/pjfanning/jsr311-compat/
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?