YARN-11634. Speed-up TestTimelineClient #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TimelineConnector.class has a hardcoded 1 minute connection time out, what makes the TestTimelineClient to a long running test (~15:30 min). Decrease the timeout to 10ms will speed up the test run (~56 sec).
brumi1024
reviewed
Dec 19, 2023
| @@ -78,6 +78,7 @@ public void setup() { | |||
| conf.setBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, true); | |||
| conf.setFloat(YarnConfiguration.TIMELINE_SERVICE_VERSION, 1.0f); | |||
| client = createTimelineClient(conf); | |||
| TimelineConnector.DEFAULT_SOCKET_TIMEOUT = 10; | |||
There was a problem hiding this comment.
Do you see a chance that test could fail due to a quite low socket timeout?
There was a problem hiding this comment.
well... it is a good question that made me wonder in case of a successful connection how long the KerberosAuthenticator#190 connect is running, and the plot-twist i just realized all of the tests expect timeout here 😅
If you add a some debug point before and after this line we can observe the debug point after the connect will never be triggered, so technically we can also write 1ms here, the tests can not be broken
|
💔 -1 overall
This message was automatically generated. |
brumi1024
approved these changes
Dec 20, 2023
| @@ -78,6 +78,7 @@ public void setup() { | |||
| conf.setBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, true); | |||
| conf.setFloat(YarnConfiguration.TIMELINE_SERVICE_VERSION, 1.0f); | |||
| client = createTimelineClient(conf); | |||
| TimelineConnector.DEFAULT_SOCKET_TIMEOUT = 10; | |||
|
Merging to trunk. |
This was referenced Jan 6, 2024
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
The TimelineConnector.class has a hardcoded 1 minute connection time out, what makes the TestTimelineClient to a long running test (~15:30 min). Decrease the timeout to 10ms will speed up the test run (~56 sec).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The TimelineConnector.class has a hardcoded 1 minute connection time out, what makes the TestTimelineClient to a long running test (~15:30 min). Decrease the timeout to 10ms will speed up the test run (~56 sec).
How was this patch tested?