YARN-11643. Skip unnecessary pre-check in Multi Node Placement

[laysfire]

Description of PR

JIRA: YARN-11643. Skip unnecessary pre-check in Multi Node Placement.
Scheduler may do useless while loop when Multi Node Placement enable. This lead to poor schedule performance in worst-case scenario.

How was this patch tested?

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	31m 18s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 26s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	0m 30s		trunk passed
+1 💚	mvnsite	0m 34s		trunk passed
+1 💚	javadoc	0m 35s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 31s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	1m 14s		trunk passed
+1 💚	shadedclient	19m 54s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 25s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 26s		the patch passed
+1 💚	compile	0m 24s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	0m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 20s		the patch passed
+1 💚	mvnsite	0m 24s		the patch passed
+1 💚	javadoc	0m 27s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 26s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	1m 4s		the patch passed
+1 💚	shadedclient	19m 53s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	577m 3s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 22s		The patch does not generate ASF License warnings.
		658m 39s

Reason	Tests
Failed junit tests	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerWithMultiResourceTypes
	hadoop.yarn.server.resourcemanager.TestResourceTrackerService
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAMAllocatedToNonExclusivePartition
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerMultiNodes
	hadoop.yarn.server.resourcemanager.ahs.TestRMApplicationHistoryWriter
	hadoop.yarn.server.resourcemanager.TestCapacitySchedulerMetrics
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestAbsoluteResourceWithAutoQueue
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue
	hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
	hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesSchedulerActivitiesWithMultiNodesEnabled
	hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler
	hadoop.yarn.server.resourcemanager.TestApplicationCleanup
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerAutoQueueCreation
	hadoop.yarn.server.resourcemanager.security.TestAMRMTokens
	hadoop.yarn.server.resourcemanager.TestKillApplicationWithRMHA
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerMultiNodesWithPreemption
	hadoop.yarn.server.resourcemanager.TestRMHAForAsyncScheduler
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimitsByPartition
	hadoop.yarn.server.resourcemanager.rmapp.TestNodesListManager
	hadoop.yarn.server.resourcemanager.TestNodeBlacklistingOnAMFailures
	hadoop.yarn.server.resourcemanager.scheduler.policy.TestFairOrderingPolicy
	hadoop.yarn.server.resourcemanager.TestApplicationMasterServiceFair
	hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerHealth
	hadoop.yarn.server.resourcemanager.TestDecommissioningNodesWatcher
	hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens
	hadoop.yarn.server.resourcemanager.TestResourceManager
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestQueueState
	hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCResponseId
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
	hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerOvercommit
	hadoop.yarn.server.resourcemanager.rmapp.TestApplicationLifetimeMonitor
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerMaxParallelApps
	hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesForCSWithPartitions
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestWorkPreservingRMRestartForNodeLabel
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCSAllocateCustomResource
	hadoop.yarn.server.resourcemanager.TestSignalContainer
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestReservations
	hadoop.yarn.server.resourcemanager.webapp.TestRMWebServiceAppsNodelabel
	hadoop.yarn.server.resourcemanager.rmcontainer.TestRMContainerImpl
	hadoop.yarn.server.resourcemanager.TestAMAuthorization
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerLazyPreemption
	hadoop.yarn.server.resourcemanager.resource.TestResourceProfiles
	hadoop.yarn.server.resourcemanager.volume.csi.TestVolumeProcessor
	hadoop.yarn.server.resourcemanager.scheduler.TestSchedulerUtils
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodes
	hadoop.yarn.server.resourcemanager.scheduler.TestSchedulingWithAllocationRequestId
	hadoop.yarn.server.resourcemanager.TestApplicationMasterLauncher
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationLimits
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerApps
	hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCNodeUpdates
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationPriority
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerSchedulingRequestUpdate
	hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerWeightMode
	hadoop.yarn.server.resourcemanager.TestContainerResourceUsage

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6426/1/artifact/out/Dockerfile
GITHUB PR	#6426
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux fa5c654df1eb 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 9895ba1
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6426/1/testReport/
Max. process+thread count	1162 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6426/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 21s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 16s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	0m 32s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	javadoc	0m 36s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	1m 6s		trunk passed
+1 💚	shadedclient	19m 57s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 28s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 28s		the patch passed
+1 💚	compile	0m 24s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	0m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 23s		the patch passed
+1 💚	mvnsite	0m 27s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 27s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	1m 7s		the patch passed
+1 💚	shadedclient	19m 57s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	86m 1s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	asflicense	0m 23s		The patch does not generate ASF License warnings.
		168m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6426/2/artifact/out/Dockerfile
GITHUB PR	#6426
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux f212591512f7 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 4c340e6
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6426/2/testReport/
Max. process+thread count	970 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6426/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
			_ Prechecks _
+1 💚	dupname	0m 01s		No case conflicting files found.
+0 🆗	spotbugs	0m 00s		spotbugs executables are not available.
+0 🆗	codespell	0m 00s		codespell was not available.
+0 🆗	detsecrets	0m 00s		detect-secrets was not available.
+1 💚	@author	0m 01s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 00s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	108m 43s		trunk passed
+1 💚	compile	7m 28s		trunk passed
+1 💚	checkstyle	5m 38s		trunk passed
+1 💚	mvnsite	7m 06s		trunk passed
+1 💚	javadoc	6m 45s		trunk passed
+1 💚	shadedclient	179m 47s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 28s		the patch passed
+1 💚	compile	3m 52s		the patch passed
+1 💚	javac	3m 52s		the patch passed
+1 💚	blanks	0m 00s		The patch has no blanks issues.
+1 💚	checkstyle	2m 43s		the patch passed
+1 💚	mvnsite	4m 04s		the patch passed
+1 💚	javadoc	3m 38s		the patch passed
+1 💚	shadedclient	190m 47s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	6m 37s		The patch does not generate ASF License warnings.
		510m 34s

Subsystem	Report/Notes
GITHUB PR	#6426
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	MINGW64_NT-10.0-17763 80fcb844f29c 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool	maven
Personality	/c/hadoop/dev-support/bin/hadoop.sh
git revision	trunk / 4c340e6
Default Java	Azul Systems, Inc.-1.8.0_332-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6426/1/testReport/
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6426/1/console
versions	git=2.44.0.windows.1
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.