HADOOP-19052.Hadoop use Shell command to get the count of the hard link which takes a lot of time #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nk which takes a lot of time
|
🎊 +1 overall
This message was automatically generated. |
yangjiandan
reviewed
Feb 23, 2024
| @@ -219,6 +230,16 @@ public void testGetLinkCount() throws IOException { | |||
| assertEquals(1, getLinkCount(x3)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGetLinkCountFromFileAttribute() throws IOException { | |||
| assertTrue(supportsHardLink(x1)); | |||
There was a problem hiding this comment.
supportsHardLink(x1) may be false if os is not unix style
| @@ -220,6 +226,10 @@ public static int getLinkCount(File fileName) throws IOException { | |||
| throw new FileNotFoundException(fileName + " not found."); | |||
| } | |||
|
|
|||
| if (Files.getFileStore(fileName.toPath()).supportsFileAttributeView(FileAttributeView)) { | |||
There was a problem hiding this comment.
Files.getFileStore(fileName.toPath()).supportsFileAttributeView(FileAttributeView) should be abstracted into a method, and be tested it in UT.
…nk which takes a lot of time
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
As described in HADOOP_19052. When we try to append a file, we will execute method
getHardLinkCounttwice. When we execute methodgetHardLinkCountjava will start a new process to execute a shell command and wait for it to fork. When the QPS ofappendexecution is very high, methodgetHardLinkCountwill take a long time to finish which will cause a long-time wait to acquire lock.I used another method to get the linkCount of a file whose file store supports the file attributes identified by the given file attribute view. This method does not start a new process and will finish in very short time even if the QPS of
appendexecution is high.How was this patch tested?
I add a new UT testGetLinkCountFromFileAttribute and a public method supportsHardLink to get whether or not this file store supports the file attributes identified by the given file attribute view.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?