HDFS-13603: do not propagate ExecutionException and add maxRetries li… #6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…mit to NameNode edek cache warmup
|
💔 -1 overall
This message was automatically generated. |
simbadzina
requested changes
May 10, 2024
| @@ -269,12 +269,23 @@ public ValueQueue(final int numValues, final float lowWaterMark, long expiry, | |||
| * Initializes the Value Queues for the provided keys by calling the | |||
| * fill Method with "numInitValues" values | |||
| * @param keyNames Array of key Names | |||
| * @throws ExecutionException executionException. | |||
| * @throws IOException if no successful initialization for any key | |||
There was a problem hiding this comment.
The wording here is confusing. One way to read this is if any key. fails to initialize, then an except will be thrown. But IIUC an exception will be thrown if all keys fail to initialize.
| @@ -537,12 +537,12 @@ static boolean isInAnEZ(final FSDirectory fsd, final INodesInPath iip) | |||
| * then launch up a separate thread to warm them up. | |||
| */ | |||
| static void warmUpEdekCache(final ExecutorService executor, | |||
| final FSDirectory fsd, final int delay, final int interval) { | |||
| final FSDirectory fsd, final int delay, final int interval, final int maxRetries) { | |||
There was a problem hiding this comment.
Can you edit a comment in the function documentation to indicate that the warm up is best effort.
| success = true; | ||
| break; | ||
| } catch (IOException ioe) { | ||
| lastSeenIOE = ioe; | ||
| if (sinceLastLog >= logCoolDown) { |
There was a problem hiding this comment.
sinceLastLog is no longer really used now. You can just print the failure since the retry count is limited.
|
|
||
| verify(kpMock, times(maxRetries)).warmUpEncryptedKeys(any()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you add a test cache in which one or some of the keys are successfully warmed up, while others aren't.
| } | ||
|
|
||
| if (keyNames.length > 0 && successfulInitializations == 0) { | ||
| throw new IOException("Failed to initialize any queue for the provided keys.", lastException); |
There was a problem hiding this comment.
It seems you've made warm up a best error operation. If so, there should be no need to through an exception here. Just logging a warning should be enough.
CloudZY
reviewed
May 10, 2024
| } | ||
| sinceLastLog += retryInterval; |
There was a problem hiding this comment.
It does not get updated since initial settings. Shall we add it back or remove its usages completely as Simba said?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA = HDFS-13603
The ekek cache warm up thread should not fail the whole warmup of other keys if an invalid key is encountered.
We have observed infinite retries to KMS if one of Encryption Key is not available.
Change it to
How was this patch tested?
Added unit test TestFSDirEncryptionZoneOp for retry behavior
Related unit tests
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles? NA