New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17503. Unreleased volume references because of OOM. #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
@Hexiaoqiao Hi~ sir. Could you please help me review this PR when you are free? Thanks. |
ZanderXu
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged. Thanks @zhuzilong2013 for your contribution. |
Thanks @ZanderXu for your review and merge~ |
K0K0V0K
pushed a commit
to K0K0V0K/hadoop
that referenced
this pull request
May 17, 2024
K0K0V0K
pushed a commit
to K0K0V0K/hadoop
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Refer to HDFS-17503.
When BlockSender throws an error because of OOM,the volume reference obtained by the thread is not released,which causes the thread trying to remove the volume to wait and fall into an infinite loop.
I found HDFS-15963 catched exception and release volume reference. But it did not handle the case of throwing errors. I think "catch (Throwable t)" should be used instead of "catch (IOException ioe)".
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?