Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-17503. Unreleased volume references because of OOM. #6782

Merged
merged 1 commit into from May 10, 2024

Conversation

zhuzilong2013
Copy link
Contributor

Description of PR

Refer to HDFS-17503.
When BlockSender throws an error because of OOM,the volume reference obtained by the thread is not released,which causes the thread trying to remove the volume to wait and fall into an infinite loop.
I found HDFS-15963 catched exception and release volume reference. But it did not handle the case of throwing errors. I think "catch (Throwable t)" should be used instead of "catch (IOException ioe)".

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 00s No case conflicting files found.
+0 🆗 spotbugs 0m 01s spotbugs executables are not available.
+0 🆗 codespell 0m 01s codespell was not available.
+0 🆗 detsecrets 0m 01s detect-secrets was not available.
+1 💚 @author 0m 00s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 00s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 94m 08s trunk passed
+1 💚 compile 6m 41s trunk passed
+1 💚 checkstyle 5m 12s trunk passed
+1 💚 mvnsite 7m 34s trunk passed
+1 💚 javadoc 6m 25s trunk passed
+1 💚 shadedclient 159m 41s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 57s the patch passed
+1 💚 compile 3m 48s the patch passed
+1 💚 javac 3m 48s the patch passed
+1 💚 blanks 0m 01s The patch has no blanks issues.
+1 💚 checkstyle 2m 30s the patch passed
+1 💚 mvnsite 4m 26s the patch passed
+1 💚 javadoc 3m 41s the patch passed
+1 💚 shadedclient 168m 39s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 6m 47s The patch does not generate ASF License warnings.
452m 05s
Subsystem Report/Notes
GITHUB PR #6782
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname MINGW64_NT-10.0-17763 06e84c9dc0f5 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys
Build tool maven
Personality /c/hadoop/dev-support/bin/hadoop.sh
git revision trunk / b25c350
Default Java Azul Systems, Inc.-1.8.0_332-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6782/1/testReport/
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6782/1/console
versions git=2.45.0.windows.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhuzilong2013
Copy link
Contributor Author

@Hexiaoqiao Hi~ sir. Could you please help me review this PR when you are free? Thanks.

Copy link
Contributor

@ZanderXu ZanderXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZanderXu ZanderXu merged commit 700b3e4 into apache:trunk May 10, 2024
1 of 4 checks passed
@ZanderXu
Copy link
Contributor

Merged. Thanks @zhuzilong2013 for your contribution.

@zhuzilong2013
Copy link
Contributor Author

Thanks @ZanderXu for your review and merge~

K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
K0K0V0K pushed a commit to K0K0V0K/hadoop that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants