Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity #6787
HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload Identity #6787
Changes from all commits
6629f9c
0a649d5
2632811
088b5c3
d47fd76
7d4cdb3
524ee18
08da2ea
06fa885
fe75cd3
81c1b62
3aeacfa
329e3c9
f8be1ca
781b831
20a660a
7a2c74d
9a4a15e
962f86a
af69bf2
eb2b402
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this expiring variable now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily. It is just there for a cleaner code.
If we get rid of it, we will have this replaced with
elapsedTimeSinceLastTokenRefreshInMillis < 0
at two places.Seems okay to me that way as well.
Will take this,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah..sorry somehow I missed that expiring is getting returned. I think it was better before.
Do you mind reverting this part?
so sorry for the rework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted...