Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-17531. [Discuss] RBF: Aynchronous router RPC. #6838

Closed
wants to merge 6 commits into from

Conversation

KeeProMise
Copy link
Contributor

@KeeProMise KeeProMise commented May 19, 2024

Description of PR

This PR is mainly for your reference.
Welcome to discuss it. https://issues.apache.org/jira/browse/HDFS-17531

How was this patch tested?

Currently, I have modified these UTs to use asynchronous router for your reference.

TestNoNamenodesAvailableLongTime
TestObserverWithRouter
TestRouterFederationRename
TestRouterFederationRenamePermission
TestRouterQuota
TestRouterRefreshSuperUserGroupsConfiguration
TestRouterRpc
TestRouterRpcMultiDestination
TestRouterRPCMultipleDestinationMountTableResolver
TestRouterRpcSingleNS
TestRouterRpcStoragePolicySatisfier
TestRouterUserMappings

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@KeeProMise KeeProMise changed the title HDFS-17531. RBF: Aynchronous router RPC. HDFS-17531. [Discuss] RBF: Aynchronous router RPC. May 19, 2024
@ayushtkn
Copy link
Member

passing by: discuss threads should be on hadoop dev mailing lists

@slfan1989
Copy link
Contributor

slfan1989 commented May 19, 2024

@KeeProMise Thanks for the contribution! This pr is too large and it seems that it cannot be reviewed.

Let’s first follow the process and discuss it on the hadoop dev mailing list. After the discussion is passed, we can consider splitting the pr for easier review.

@KeeProMise
Copy link
Contributor Author

@ayushtkn @slfan1989 hi, thanks for you replay, I sent the discussion to common-dev@hadoop.apache.org.

@slfan1989
Copy link
Contributor

slfan1989 commented May 21, 2024

@ayushtkn @slfan1989 hi, thanks for you replay, I sent the discussion to common-dev@hadoop.apache.org.

@KeeProMise This pr has too many changes and affects multiple modules, causing the compilation to time out. I have seen the discussion emails, and the usual discussion process may take 5-7 days.

@KeeProMise
Copy link
Contributor Author

Thank you again for your attention. I will split this huge PR into small PRs. You can review the PRs in the subtasks. I will close this huge PR.

@KeeProMise KeeProMise closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants