Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-18610: [ABFS] [Backport to 3.4] OAuth2 Token Provider support for Azure Workload Identity #6881

Merged
merged 2 commits into from
Jun 18, 2024
Merged

HADOOP-18610: [ABFS] [Backport to 3.4] OAuth2 Token Provider support for Azure Workload Identity #6881

merged 2 commits into from
Jun 18, 2024

Conversation

anujmodi2021
Copy link
Contributor

Description of PR

Jira: https://issues.apache.org/jira/browse/HADOOP-18610
PR in trunk: #6787
Commit Cherry-picked: 005030f

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@anujmodi2021
HADOOP-18610: [ABFS] OAuth2 Token Provider support for Azure Workload…
1879b3a 
… Identity (apache#6787)


Add support for Azure Active Directory (Azure AD) workload identities which integrate with the Kubernetes's native capabilities to federate with any external identity provider.

Contributed By: Anuj Modi
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 21m 23s Docker failed to build run-specific yetus/hadoop:tp-29686}.
Subsystem Report/Notes
GITHUB PR #6881
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6881/1/console
versions git=2.34.1
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@anujmodi2021
Copy link
Contributor Author

:::: AGGREGATED TEST RESULT ::::

============================================================
HNS-OAuth

[ERROR] testGetAclCallOnHnsConfigAbsence(org.apache.hadoop.fs.azurebfs.ITestAzureBlobFileSystemInitAndCreate) Time elapsed: 5.01 s <<< FAILURE!

[WARNING] Tests run: 141, Failures: 0, Errors: 0, Skipped: 2
[ERROR] Tests run: 622, Failures: 1, Errors: 0, Skipped: 76
[WARNING] Tests run: 411, Failures: 0, Errors: 0, Skipped: 57

============================================================
HNS-SharedKey

[ERROR] testGetAclCallOnHnsConfigAbsence(org.apache.hadoop.fs.azurebfs.ITestAzureBlobFileSystemInitAndCreate) Time elapsed: 5.08 s <<< FAILURE!

[WARNING] Tests run: 141, Failures: 0, Errors: 0, Skipped: 3
[ERROR] Tests run: 622, Failures: 1, Errors: 0, Skipped: 28
[WARNING] Tests run: 411, Failures: 0, Errors: 0, Skipped: 44

============================================================
NonHNS-SharedKey

[ERROR] testGetAclCallOnHnsConfigAbsence(org.apache.hadoop.fs.azurebfs.ITestAzureBlobFileSystemInitAndCreate) Time elapsed: 4.438 s <<< FAILURE!

[WARNING] Tests run: 141, Failures: 0, Errors: 0, Skipped: 9
[ERROR] Tests run: 606, Failures: 1, Errors: 0, Skipped: 268
[WARNING] Tests run: 411, Failures: 0, Errors: 0, Skipped: 47

============================================================
AppendBlob-HNS-OAuth

[ERROR] testGetAclCallOnHnsConfigAbsence(org.apache.hadoop.fs.azurebfs.ITestAzureBlobFileSystemInitAndCreate) Time elapsed: 5.117 s <<< FAILURE!

[WARNING] Tests run: 141, Failures: 0, Errors: 0, Skipped: 2
[ERROR] Tests run: 622, Failures: 1, Errors: 0, Skipped: 78
[WARNING] Tests run: 411, Failures: 0, Errors: 0, Skipped: 81

Time taken: 55 mins 12 secs.

@anujmodi2021 anujmodi2021 marked this pull request as ready for review June 17, 2024 15:53
@anujmodi2021
Copy link
Contributor Author

Hi @mukund-thakur
Please merge this PR if looks good.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+0 🆗 yamllint 0m 1s yamllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 6 new or modified test files.
_ branch-3.4 Compile Tests _
+1 💚 mvninstall 44m 13s branch-3.4 passed
+1 💚 compile 0m 38s branch-3.4 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 compile 0m 35s branch-3.4 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 checkstyle 0m 32s branch-3.4 passed
+1 💚 mvnsite 0m 42s branch-3.4 passed
+1 💚 javadoc 0m 39s branch-3.4 passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 0m 35s branch-3.4 passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 spotbugs 1m 4s branch-3.4 passed
+1 💚 shadedclient 33m 13s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 29s the patch passed
+1 💚 compile 0m 29s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javac 0m 29s the patch passed
+1 💚 compile 0m 28s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 javac 0m 28s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 19s the patch passed
+1 💚 mvnsite 0m 30s the patch passed
+1 💚 javadoc 0m 26s the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2
+1 💚 javadoc 0m 26s the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
+1 💚 spotbugs 1m 5s the patch passed
+1 💚 shadedclient 33m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 17s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
141m 14s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6881/2/artifact/out/Dockerfile
GITHUB PR #6881
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint yamllint
uname Linux 75866659f75f 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 0129bdd
Default Java Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6881/2/testReport/
Max. process+thread count 702 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6881/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@mukund-thakur
Copy link
Contributor

@anujmodi2021 What is this one test failure testGetAclCallOnHnsConfigAbsence?

@anujmodi2021
Copy link
Contributor Author

@anujmodi2021 What is this one test failure testGetAclCallOnHnsConfigAbsence?

I believe this test started failing after the PR#6752 got merged.
I investigated this and this is due to an issue on test code side only. Production code is all fine.
@saxenapranav or I will take up this fix in our upcoming PRs to trunk.

Should we wait for the fix to be done on trunk first or should we fix this here itself to unblock this PR??

@mukund-thakur
Copy link
Contributor

We don't need to wait but please create a tracking jira and mention here.

@mukund-thakur mukund-thakur merged commit 468b7e5 into apache:branch-3.4 Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anujmodi2021 @hadoop-yetus @mukund-thakur