Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-9433. Remove unused constants in YARN resource manager #706

Closed
wants to merge 1 commit into from

Conversation

hextriclosan
Copy link
Contributor

I've checked that these constants are not used in the project at all.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 33 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1103 trunk passed
+1 compile 46 trunk passed
+1 checkstyle 37 trunk passed
+1 mvnsite 48 trunk passed
+1 shadedclient 740 branch has no errors when building and testing our client artifacts.
-1 findbugs 77 hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in trunk has 2 extant Findbugs warnings.
+1 javadoc 29 trunk passed
_ Patch Compile Tests _
+1 mvninstall 41 the patch passed
+1 compile 43 the patch passed
+1 javac 43 the patch passed
+1 checkstyle 32 the patch passed
+1 mvnsite 48 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 718 patch has no errors when building and testing our client artifacts.
+1 findbugs 84 the patch passed
+1 javadoc 26 the patch passed
_ Other Tests _
-1 unit 4486 hadoop-yarn-server-resourcemanager in the patch failed.
-1 asflicense 23 The patch generated 1 ASF License warnings.
7645
Reason Tests
Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMService
hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-706/1/artifact/out/Dockerfile
GITHUB PR #706
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 1d022b726b71 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / bb8dda2
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-706/1/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-706/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-706/1/testReport/
asflicense https://builds.apache.org/job/hadoop-multibranch/job/PR-706/1/artifact/out/patch-asflicense-problems.txt
Max. process+thread count 925 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-706/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hextriclosan
Copy link
Contributor Author

test4tests: unused code deleted no reason to add/delete unit any tests
findbugs: 2 warnings aren't related to code changes
unit: failures aren't caused by the fix
asflicense: license warning is about of absence of license header but modified file has the license header

@aajisaka
Copy link
Member

+1

@aajisaka
Copy link
Member

Committed to trunk. Thank you @hextriclosan

@aajisaka aajisaka closed this Apr 10, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
… descriptors

Hybrid Table Descriptors, e.g. CachingTableDescriptor, should take both tables as a constructor param instead of using withXYZ methods. This is better because they are required for the hybrid descriptor to work, and it helps with type inference for the descriptor.

Author: Wei Song <wsong@linkedin.com>

Reviewers: Peng Du <pdu@linkedin.com>

Closes apache#706 from weisong44/SAMZA-1948 and squashes the following commits:

53444419 [Wei Song] Updated based on review comments
39d9ab00 [Wei Song] SAMZA-1948 Updated hybrid table descriptors to take underlying table descriptors
a56c28d [Wei Song] Merge remote-tracking branch 'upstream/master'
097958c [Wei Song] Merge remote-tracking branch 'upstream/master'
05822f0 [Wei Song] Merge remote-tracking branch 'upstream/master'
f748050 [Wei Song] Merge remote-tracking branch 'upstream/master'
7706ab1 [Wei Song] Merge remote-tracking branch 'upstream/master'
f5731b1 [Wei Song] Merge remote-tracking branch 'upstream/master'
1e5de45 [Wei Song] Merge remote-tracking branch 'upstream/master'
c85604e [Wei Song] Merge remote-tracking branch 'upstream/master'
242d844 [Wei Song] Merge remote-tracking branch 'upstream/master'
ec7d840 [Wei Song] Merge remote-tracking branch 'upstream/master'
e19b4dc [Wei Song] Merge remote-tracking branch 'upstream/master'
8ee7844 [Wei Song] Merge remote-tracking branch 'upstream/master'
1c6a2ea [Wei Song] Merge remote-tracking branch 'upstream/master'
a6c94ad [Wei Song] Merge remote-tracking branch 'upstream/master'
41299b5 [Wei Song] Merge remote-tracking branch 'upstream/master'
239a095 [Wei Song] Merge remote-tracking branch 'upstream/master'
eca0020 [Wei Song] Merge remote-tracking branch 'upstream/master'
5156239 [Wei Song] Merge remote-tracking branch 'upstream/master'
de708f5 [Wei Song] Merge remote-tracking branch 'upstream/master'
df2f8d7 [Wei Song] Merge remote-tracking branch 'upstream/master'
f28b491 [Wei Song] Merge remote-tracking branch 'upstream/master'
4782c61 [Wei Song] Merge remote-tracking branch 'upstream/master'
0440f75 [Wei Song] Merge remote-tracking branch 'upstream/master'
aae0f38 [Wei Song] Merge remote-tracking branch 'upstream/master'
a15a7c9 [Wei Song] Merge remote-tracking branch 'upstream/master'
5cbf9af [Wei Song] Merge remote-tracking branch 'upstream/master'
3f7ed71 [Wei Song] Added self to committer list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants