Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-1456. Stop the datanode, when any datanode statemachine state is… #769

Merged
merged 4 commits into from
Apr 26, 2019
Merged

HDDS-1456. Stop the datanode, when any datanode statemachine state is… #769

merged 4 commits into from
Apr 26, 2019

Conversation

bharatviswa504
Copy link
Contributor

… set to shutdown.

@bharatviswa504 bharatviswa504 self-assigned this Apr 24, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 22 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
0 mvndep 306 Maven dependency ordering for branch
+1 mvninstall 1040 trunk passed
+1 compile 1018 trunk passed
+1 checkstyle 137 trunk passed
+1 mvnsite 207 trunk passed
+1 shadedclient 1075 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 113 trunk passed
+1 javadoc 108 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 105 the patch passed
+1 compile 966 the patch passed
+1 javac 966 the patch passed
+1 checkstyle 126 the patch passed
+1 mvnsite 111 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 608 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 116 the patch passed
+1 javadoc 70 the patch passed
_ Other Tests _
-1 unit 60 container-service in the patch failed.
-1 unit 99 server-scm in the patch failed.
-1 unit 762 integration-test in the patch failed.
+1 asflicense 56 The patch does not generate ASF License warnings.
7046
Reason Tests
Failed junit tests hadoop.ozone.container.common.volume.TestVolumeSetDiskChecks
hadoop.hdds.scm.container.TestReplicationManager
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-769/1/artifact/out/Dockerfile
GITHUB PR #769
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux fe90552653d6 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / a703dae
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/1/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/1/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-769/1/testReport/
Max. process+thread count 5309 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-769/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor Author

Thank You @arp7 for the review and offline discussion.
I have addressed review comments

bharatviswa504
bharatviswa504 commented Apr 25, 2019
View reviewed changes
...e/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestVolumeSetDiskChecks.java
@@ -141,6 +143,9 @@ HddsVolumeChecker getVolumeChecker(Configuration configuration)
return new DummyChecker(configuration, new Timer(), numVolumes);
}
};

assertEquals(volumeSet.getFailedVolumesList().size(), numVolumes);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is updated like this due to code reordering. As we are calling checkAllVolumes() when only volumeMap size is not zero.

@arp7
Copy link
Contributor

arp7 commented Apr 25, 2019

+1

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 24 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 61 Maven dependency ordering for branch
+1 mvninstall 1031 trunk passed
+1 compile 967 trunk passed
+1 checkstyle 141 trunk passed
+1 mvnsite 167 trunk passed
+1 shadedclient 1014 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 93 trunk passed
+1 javadoc 83 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 91 the patch passed
+1 compile 924 the patch passed
+1 javac 924 the patch passed
+1 checkstyle 133 the patch passed
+1 mvnsite 110 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 676 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 127 the patch passed
+1 javadoc 105 the patch passed
_ Other Tests _
-1 unit 68 container-service in the patch failed.
+1 unit 113 server-scm in the patch passed.
-1 unit 789 integration-test in the patch failed.
+1 asflicense 48 The patch does not generate ASF License warnings.
6737
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-769/2/artifact/out/Dockerfile
GITHUB PR #769
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux e5a6a8f989b6 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b5dcf64
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/2/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-769/2/testReport/
Max. process+thread count 5325 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-769/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 57 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 27 Maven dependency ordering for branch
+1 mvninstall 1332 trunk passed
+1 compile 1534 trunk passed
+1 checkstyle 186 trunk passed
+1 mvnsite 253 trunk passed
+1 shadedclient 1234 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 103 trunk passed
+1 javadoc 95 trunk passed
_ Patch Compile Tests _
0 mvndep 21 Maven dependency ordering for patch
+1 mvninstall 100 the patch passed
+1 compile 961 the patch passed
+1 javac 961 the patch passed
+1 checkstyle 145 the patch passed
+1 mvnsite 120 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 728 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 118 the patch passed
+1 javadoc 88 the patch passed
_ Other Tests _
-1 unit 75 container-service in the patch failed.
+1 unit 125 server-scm in the patch passed.
-1 unit 1373 integration-test in the patch failed.
+1 asflicense 50 The patch does not generate ASF License warnings.
8543
Reason Tests
Failed junit tests hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
hadoop.ozone.container.TestContainerReplication
hadoop.ozone.client.rpc.TestCommitWatcher
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-769/3/artifact/out/Dockerfile
GITHUB PR #769
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 59e0fa299b64 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b5dcf64
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/3/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/3/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-769/3/testReport/
Max. process+thread count 4932 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-769/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 40 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 20 Maven dependency ordering for branch
+1 mvninstall 1069 trunk passed
+1 compile 1026 trunk passed
+1 checkstyle 136 trunk passed
+1 mvnsite 124 trunk passed
+1 shadedclient 1025 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 103 trunk passed
+1 javadoc 97 trunk passed
_ Patch Compile Tests _
0 mvndep 21 Maven dependency ordering for patch
+1 mvninstall 97 the patch passed
+1 compile 965 the patch passed
+1 javac 965 the patch passed
+1 checkstyle 131 the patch passed
+1 mvnsite 125 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 716 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 118 the patch passed
+1 javadoc 95 the patch passed
_ Other Tests _
-1 unit 79 container-service in the patch failed.
+1 unit 126 server-scm in the patch passed.
-1 unit 1126 integration-test in the patch failed.
+1 asflicense 51 The patch does not generate ASF License warnings.
7290
Reason Tests
Failed junit tests hadoop.ozone.web.client.TestKeysRatis
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.ozone.container.TestContainerReplication
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-769/4/artifact/out/Dockerfile
GITHUB PR #769
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux c10765da7205 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b5dcf64
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/4/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-769/4/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-769/4/testReport/
Max. process+thread count 5247 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-hdds/server-scm hadoop-ozone/integration-test U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-769/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504 bharatviswa504 merged commit 43b2a4b into apache:trunk Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arp7 arp7 arp7 left review comments

@hanishakoneru hanishakoneru Awaiting requested review from hanishakoneru

Assignees

@bharatviswa504 bharatviswa504

Labels
ozone
Projects
None yet
Milestone
No milestone
3 participants
@bharatviswa504 @hadoop-yetus @arp7