HDDS-1483:Fix javadoc #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bharatviswa504 Thanks for filing the JIRA. Pls help to review/commit. |
|
💔 -1 overall
This message was automatically generated. |
|
Thank You @dineshchitlangia for fixing this issue. |
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
This patch consists of the following changes: * Unify the different methods present in the TaskNameGrouper interface. This will enable us to have a single interface method usable for both the yarn and standalone models. * Generate locationId aware task assignment to processors in standalone. * Move the task assignment persistence logic from a custom `TaskNameGrouper` implementation to `JobModelManager`, so that this works for any kind of custom group. * General code clean up in `JobModelManager`, `TaskAssignmentManager` and in other samza internal classes. * Read/write taskLocality of the processors in standalone. * Updated the existing java docs and added java docs where they were missing. Testing: * Fixed the existing unit-tests due to the changes. * Added new unit tests for the functionality changed added as a part of this patch. * Tested this patch with a sample job from `hello-samza` project and verified that it works as expected. Please refer to [SEP-11](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=75957309) for more details. Author: Shanthoosh Venkataraman <spvenkat@usc.edu> Author: Shanthoosh Venkataraman <svenkata@linkedin.com> Author: svenkata <svenkataraman@linkedin.com> Reviewers: Prateek M<pmaheshw@linkedin.com> Closes apache#790 from shanthoosh/task_name_grouper_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.