HDDS-1474. ozone.scm.datanode.id config should take path for a dir #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label ozone |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
/retest |
|
💔 -1 overall
This message was automatically generated. |
|
The failing acceptance tests and unit tests are not related to this change. The trunk is broken and these tests need to be fixed in trunk. |
There was a problem hiding this comment.
Thanks @vivekratnavel for working on this. LGTM overall. Few minor comments.
...service/src/test/java/org/apache/hadoop/ozone/container/common/TestDatanodeStateMachine.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/hdds/scm/HddsServerUtil.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Thank you @vivekratnavel .
Just one Nitpick. +1 with that addressed.
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
+1. Thanks @vivekratnavel . Test failures are unrelated. I will merge this shortly. |
anuengineer
reviewed
May 9, 2019
| @@ -20,7 +20,7 @@ metadata: | |||
| name: config | |||
| data: | |||
| OZONE-SITE.XML_hdds.datanode.dir: /data/storage | |||
| OZONE-SITE.XML_ozone.scm.datanode.id: /data/datanode.id | |||
| OZONE-SITE.XML_ozone.scm.datanode.id.dir: /data/datanode.id | |||
There was a problem hiding this comment.
Sorry to comment so late, is this wrong ? Shouldn't this be /data instead of /data/datanode.id ?
anuengineer
reviewed
May 9, 2019
| @@ -20,7 +20,7 @@ metadata: | |||
| name: config | |||
| data: | |||
| OZONE-SITE.XML_hdds.datanode.dir: /data/storage | |||
| OZONE-SITE.XML_ozone.scm.datanode.id: /data/datanode.id | |||
| OZONE-SITE.XML_ozone.scm.datanode.id.dir: /data/datanode.id | |||
There was a problem hiding this comment.
Same , /data instead of /data/datanode.id?
anuengineer
reviewed
May 9, 2019
| @@ -20,7 +20,7 @@ metadata: | |||
| name: config | |||
| data: | |||
| OZONE-SITE.XML_hdds.datanode.dir: /data/storage | |||
| OZONE-SITE.XML_ozone.scm.datanode.id: /data/datanode.id | |||
| OZONE-SITE.XML_ozone.scm.datanode.id.dir: /data/datanode.id | |||
| OZONE-SITE.XML_ozone.metadata.dirs: /data/metadata | |||
|
Thanks @anuengineer for catching this. I will revert the patch. |
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…eckpoint failures. Retry loop in the existing `KafkaCheckpointManager` implementation retries using the same `SystemProducer` instance on exception and does not recreate it. When some irrecoverable exceptions occur within the `SystemProducer`, all the subsequent produce message invocations on the `SystemProducer` instance will fail. This had made the entire retry loop on `KafkaCheckpointManager` pointless. This patch consists of the following changes: 1. This patch addresses the above problem by recreating the `SystemProducer` instance on failure and adds a unit test to verify the functionality. 2. Minor code cleanup in classes: `TestKafkaCheckpointManager` and `KafkaCheckpointManager`. Author: Shanthoosh Venkataraman <spvenkat@usc.edu> Author: Shanthoosh Venkataraman <svenkata@linkedin.com> Reviewers: Dong Lin <lindong28@gmail.com> Closes apache#792 from shanthoosh/kafka_checkpoint_manager_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and not a file.
Currently, the ozone config "ozone.scm.datanode.id" takes file path as its value. It should instead take dir path as its value and assume a standard filename "datanode.id"