HDDS-1224. Restructure code to validate the response from server in the Read path #806

bshashikant · 2019-05-09T13:55:10Z

.

hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java

hadoop-yetus · 2019-05-09T16:16:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	33	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
0	mvndep	30	Maven dependency ordering for branch
+1	mvninstall	475	trunk passed
+1	compile	259	trunk passed
+1	checkstyle	59	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	917	branch has no errors when building and testing our client artifacts.
+1	javadoc	143	trunk passed
0	spotbugs	307	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	555	trunk passed
		_ Patch Compile Tests _
0	mvndep	16	Maven dependency ordering for patch
+1	mvninstall	472	the patch passed
+1	compile	252	the patch passed
+1	javac	252	the patch passed
-0	checkstyle	34	hadoop-hdds: The patch generated 41 new + 0 unchanged - 0 fixed = 41 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	753	patch has no errors when building and testing our client artifacts.
+1	javadoc	153	the patch passed
-1	findbugs	250	hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	172	hadoop-hdds in the patch failed.
-1	unit	2339	hadoop-ozone in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		8345

Reason	Tests
FindBugs	module:hadoop-hdds
	Inconsistent synchronization of org.apache.hadoop.hdds.scm.storage.BlockInputStream.chunkIndex; locked 96% of time Unsynchronized access at BlockInputStream.java:96% of time Unsynchronized access at BlockInputStream.java:[line 303]
Failed junit tests	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.TestContainerOperations
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.client.rpc.TestCommitWatcher
	hadoop.ozone.scm.TestXceiverClientManager
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.scm.TestContainerSmallFile

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/Dockerfile
GITHUB PR	#806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 58cc9b06f2c2 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `90add05`
Default Java	1.8.0_191
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/new-findbugs-hadoop-hdds.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/testReport/
Max. process+thread count	4561 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/client U: hadoop-hdds
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-05-16T15:53:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	68	Maven dependency ordering for branch
+1	mvninstall	428	trunk passed
+1	compile	202	trunk passed
+1	checkstyle	53	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	831	branch has no errors when building and testing our client artifacts.
+1	javadoc	129	trunk passed
0	spotbugs	234	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	413	trunk passed
		_ Patch Compile Tests _
0	mvndep	26	Maven dependency ordering for patch
+1	mvninstall	396	the patch passed
+1	compile	212	the patch passed
+1	javac	212	the patch passed
-0	checkstyle	30	hadoop-hdds: The patch generated 39 new + 0 unchanged - 0 fixed = 39 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	643	patch has no errors when building and testing our client artifacts.
+1	javadoc	113	the patch passed
-1	findbugs	195	hadoop-hdds generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
-1	unit	153	hadoop-hdds in the patch failed.
-1	unit	1266	hadoop-ozone in the patch failed.
+1	asflicense	39	The patch does not generate ASF License warnings.
		7203

Reason	Tests
FindBugs	module:hadoop-hdds
	Inconsistent synchronization of org.apache.hadoop.hdds.scm.storage.BlockInputStream.chunkIndex; locked 91% of time Unsynchronized access at BlockInputStream.java:91% of time Unsynchronized access at BlockInputStream.java:[line 366]
Failed junit tests	hadoop.ozone.TestContainerOperations
	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/Dockerfile
GITHUB PR	#806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 9641a001c81b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / c15b3bc
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/diff-checkstyle-hadoop-hdds.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/new-findbugs-hadoop-hdds.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/testReport/
Max. process+thread count	5402 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hanishakoneru

Thank you @bshashikant for working on this.
I have a few comments.

hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientRatis.java

hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/ContainerProtocolCalls.java

hadoop-yetus · 2019-05-29T19:24:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	70	Maven dependency ordering for branch
+1	mvninstall	535	trunk passed
+1	compile	273	trunk passed
+1	checkstyle	87	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	886	branch has no errors when building and testing our client artifacts.
+1	javadoc	164	trunk passed
0	spotbugs	290	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	483	trunk passed
-0	patch	335	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	27	Maven dependency ordering for patch
+1	mvninstall	470	the patch passed
+1	compile	296	the patch passed
+1	javac	296	the patch passed
-0	checkstyle	40	hadoop-hdds: The patch generated 21 new + 0 unchanged - 0 fixed = 21 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	647	patch has no errors when building and testing our client artifacts.
-1	javadoc	75	hadoop-hdds generated 5 new + 14 unchanged - 0 fixed = 19 total (was 14)
+1	findbugs	481	the patch passed
		_ Other Tests _
+1	unit	237	hadoop-hdds in the patch passed.
-1	unit	1582	hadoop-ozone in the patch failed.
+1	asflicense	42	The patch does not generate ASF License warnings.
		6690

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.ozShell.TestOzoneShell
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.hdds.scm.pipeline.TestRatisPipelineProvider
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.TestMiniOzoneCluster

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/artifact/out/Dockerfile
GITHUB PR	#806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux d554bfa28f11 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `abf76ac`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/artifact/out/diff-checkstyle-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/testReport/
Max. process+thread count	5355 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hanishakoneru · 2019-05-30T19:02:12Z

Thank you @bshashikant.
LGTM. There are some checkstyle errors. Added the ozone label so that CI can run. +1 pending CI and checkstyle fixes.

bshashikant · 2019-05-31T10:00:25Z

Thaks @hanishakoneru . The updated patch addresses checkstyle and unit test failures.

hadoop-yetus · 2019-05-31T11:49:10Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	25	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	61	Maven dependency ordering for branch
+1	mvninstall	524	trunk passed
+1	compile	267	trunk passed
+1	checkstyle	75	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	940	branch has no errors when building and testing our client artifacts.
+1	javadoc	150	trunk passed
0	spotbugs	297	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	485	trunk passed
-0	patch	351	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	29	Maven dependency ordering for patch
+1	mvninstall	470	the patch passed
+1	compile	269	the patch passed
+1	javac	269	the patch passed
-0	checkstyle	41	hadoop-hdds: The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	736	patch has no errors when building and testing our client artifacts.
+1	javadoc	149	the patch passed
+1	findbugs	520	the patch passed
		_ Other Tests _
-1	unit	175	hadoop-hdds in the patch failed.
-1	unit	1231	hadoop-ozone in the patch failed.
+1	asflicense	49	The patch does not generate ASF License warnings.
		6429

Reason	Tests
Failed junit tests	hadoop.ozone.container.ozoneimpl.TestOzoneContainer
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
	hadoop.hdds.scm.pipeline.TestSCMPipelineManager
	hadoop.ozone.client.rpc.TestReadRetries

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/artifact/out/Dockerfile
GITHUB PR	#806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 8ca5cf2a0c4e 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `52128e3`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/testReport/
Max. process+thread count	5256 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

bshashikant · 2019-06-03T17:23:51Z

/retest

hadoop-yetus · 2019-06-03T17:42:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	66	Maven dependency ordering for branch
+1	mvninstall	585	trunk passed
+1	compile	271	trunk passed
+1	checkstyle	69	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	843	branch has no errors when building and testing our client artifacts.
+1	javadoc	168	trunk passed
0	spotbugs	358	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	569	trunk passed
-0	patch	399	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	28	Maven dependency ordering for patch
+1	mvninstall	512	the patch passed
+1	compile	282	the patch passed
+1	javac	282	the patch passed
-0	checkstyle	36	hadoop-hdds: The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	645	patch has no errors when building and testing our client artifacts.
+1	javadoc	174	the patch passed
+1	findbugs	590	the patch passed
		_ Other Tests _
+1	unit	230	hadoop-hdds in the patch passed.
-1	unit	1156	hadoop-ozone in the patch failed.
+1	asflicense	46	The patch does not generate ASF License warnings.
		6521

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.client.rpc.TestBlockOutputStream

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/artifact/out/Dockerfile
GITHUB PR	#806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 827c0cfcb6d8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `bd2590d`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/testReport/
Max. process+thread count	4204 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hanishakoneru · 2019-06-03T21:34:32Z

@bshashikant the test failure in TestReadRetries is related to this PR. And there are some checkstyle issues also.

hadoop-yetus · 2019-06-04T13:17:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	35	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	24	Maven dependency ordering for branch
+1	mvninstall	524	trunk passed
+1	compile	304	trunk passed
+1	checkstyle	92	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	896	branch has no errors when building and testing our client artifacts.
+1	javadoc	181	trunk passed
0	spotbugs	325	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	516	trunk passed
-0	patch	395	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	36	Maven dependency ordering for patch
+1	mvninstall	484	the patch passed
+1	compile	287	the patch passed
+1	javac	287	the patch passed
-0	checkstyle	48	hadoop-hdds: The patch generated 14 new + 0 unchanged - 0 fixed = 14 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	702	patch has no errors when building and testing our client artifacts.
-1	javadoc	71	hadoop-hdds generated 5 new + 14 unchanged - 0 fixed = 19 total (was 14)
+1	findbugs	537	the patch passed
		_ Other Tests _
+1	unit	230	hadoop-hdds in the patch passed.
-1	unit	1032	hadoop-ozone in the patch failed.
+1	asflicense	69	The patch does not generate ASF License warnings.
		6377

Reason	Tests
Failed junit tests	hadoop.ozone.scm.node.TestQueryNode

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/artifact/out/Dockerfile
GITHUB PR	#806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 598d581e8274 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `7991159`
Default Java	1.8.0_212
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/artifact/out/diff-checkstyle-hadoop-hdds.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/testReport/
Max. process+thread count	4504 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-06-04T17:11:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	68	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 3 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	187	Maven dependency ordering for branch
+1	mvninstall	499	trunk passed
+1	compile	273	trunk passed
+1	checkstyle	79	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	907	branch has no errors when building and testing our client artifacts.
+1	javadoc	168	trunk passed
0	spotbugs	351	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	539	trunk passed
-0	patch	418	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	34	Maven dependency ordering for patch
+1	mvninstall	572	the patch passed
+1	compile	302	the patch passed
+1	javac	302	the patch passed
+1	checkstyle	89	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	746	patch has no errors when building and testing our client artifacts.
+1	javadoc	195	the patch passed
+1	findbugs	588	the patch passed
		_ Other Tests _
-1	unit	202	hadoop-hdds in the patch failed.
-1	unit	1544	hadoop-ozone in the patch failed.
+1	asflicense	47	The patch does not generate ASF License warnings.
		7248

Reason	Tests
Failed junit tests	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerCommandHandler
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/artifact/out/Dockerfile
GITHUB PR	#806
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 400617ecbd07 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `827a847`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/testReport/
Max. process+thread count	4363 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-806/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hanishakoneru · 2019-06-04T17:32:00Z

Thank you @bshashikant. +1. I will merge this PR.

When the user uses Samza-SQL, they use high level declarative language (SQL) for ease and speed of implementation of their Samza Job. Therefore, monitoring the job should provide metrics at this high/logical level. This is the goal of the Samza-SQL diagnostics project. In this first baby-step, we start with instrumenting the Project operator to provide run-time metrics. Author: Shenoda Guirguis <sguirgui@sguirgui-ld2.linkedin.biz> Reviewers: Srinivasulu Punuru <spunuru@linkedin.com>, Aditya Toomula <atoomula@linkedin.com> Closes apache#806 from shenodaguirguis/samza-sql-diagnostics

bshashikant requested review from hanishakoneru and mukul1987 May 9, 2019 13:55

jiwq reviewed May 9, 2019

View reviewed changes

hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java Outdated Show resolved Hide resolved

bshashikant closed this May 16, 2019

bshashikant force-pushed the HDDS-1224 branch from c390c84 to 2595125 Compare May 16, 2019 13:21

Rebased to latest trunk.

e815258

bshashikant reopened this May 16, 2019

hanishakoneru reviewed May 28, 2019

View reviewed changes

Addressed Review Comments.

97bcc05

hanishakoneru added the ozone label May 30, 2019

Addressed Checkstyle and related uit failures.

1a328b2

Adde=ressed CheckStyle issues.

90d25c5

Addressed Test failires and checkstyle issues.

d59a67a

Fixed Checkstyle issues

f030b60

hanishakoneru merged commit e4b4fec into apache:trunk Jun 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDDS-1224. Restructure code to validate the response from server in the Read path #806

HDDS-1224. Restructure code to validate the response from server in the Read path #806

bshashikant commented May 9, 2019

hadoop-yetus commented May 9, 2019

hadoop-yetus commented May 16, 2019

hanishakoneru left a comment

hadoop-yetus commented May 29, 2019

hanishakoneru commented May 30, 2019

bshashikant commented May 31, 2019

hadoop-yetus commented May 31, 2019

bshashikant commented Jun 3, 2019

hadoop-yetus commented Jun 3, 2019

hanishakoneru commented Jun 3, 2019

hadoop-yetus commented Jun 4, 2019

hadoop-yetus commented Jun 4, 2019

hanishakoneru commented Jun 4, 2019

HDDS-1224. Restructure code to validate the response from server in the Read path #806

HDDS-1224. Restructure code to validate the response from server in the Read path #806

Conversation

bshashikant commented May 9, 2019

hadoop-yetus commented May 9, 2019

hadoop-yetus commented May 16, 2019

hanishakoneru left a comment

Choose a reason for hiding this comment

hadoop-yetus commented May 29, 2019

hanishakoneru commented May 30, 2019

bshashikant commented May 31, 2019

hadoop-yetus commented May 31, 2019

bshashikant commented Jun 3, 2019

hadoop-yetus commented Jun 3, 2019

hanishakoneru commented Jun 3, 2019

hadoop-yetus commented Jun 4, 2019

hadoop-yetus commented Jun 4, 2019

hanishakoneru commented Jun 4, 2019