HDDS-1474. "ozone.scm.datanode.id" config should take path for a dir and not a file

[vivekratnavel]

Currently, the ozone config "ozone.scm.datanode.id" takes file path as its value. It should instead take dir path as its value and assume a standard filename "datanode.id"

[anuengineer]

👍 Awesome thanks for the change. LGTM.

[vivekratnavel]

/label ozone

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
0	shelldocs	1	Shelldocs was not available.
0	yamllint	1	yamllint was not available.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	69	Maven dependency ordering for branch
+1	mvninstall	411	trunk passed
+1	compile	206	trunk passed
+1	checkstyle	58	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	842	branch has no errors when building and testing our client artifacts.
+1	javadoc	126	trunk passed
0	spotbugs	244	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	428	trunk passed
		_ Patch Compile Tests _
0	mvndep	30	Maven dependency ordering for patch
+1	mvninstall	408	the patch passed
+1	compile	215	the patch passed
+1	javac	215	the patch passed
+1	checkstyle	66	the patch passed
+1	mvnsite	0	the patch passed
+1	shellcheck	0	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	2	The patch has no ill-formed XML file.
+1	shadedclient	734	patch has no errors when building and testing our client artifacts.
+1	javadoc	129	the patch passed
+1	findbugs	449	the patch passed
		_ Other Tests _
-1	unit	156	hadoop-hdds in the patch failed.
-1	unit	1272	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		6568

Reason	Tests
Failed junit tests	hadoop.ozone.container.TestContainerReplication
	hadoop.ozone.client.rpc.TestOzoneRpcClient

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-809/1/artifact/out/Dockerfile
GITHUB PR	#809
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml shellcheck shelldocs yamllint
uname	Linux d192ceb1432e 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 2d31ccc
Default Java	1.8.0_191
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-809/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-809/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-809/1/testReport/
Max. process+thread count	4641 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-hdds/container-service hadoop-hdds/docs hadoop-ozone/dist U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-809/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

[hanishakoneru]

LGTM. +1. Will merge the PR. Thanks @vivekratnavel